Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix github-pages not displaying #3435 #3436

Merged
merged 3 commits into from Dec 8, 2023
Merged

Fix github-pages not displaying #3435 #3436

merged 3 commits into from Dec 8, 2023

Conversation

fritschldwg
Copy link
Collaborator

@fritschldwg fritschldwg commented Dec 8, 2023 •
edited

Fix github-pages not displaying

Closes: #3435

Description

Descriptive pull request text, answering:

  • Adding minimal changes to trigger new release and fix github-pages not rendering

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 8, 2023

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 8, 2023

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Nereboss
Nereboss approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@Nereboss Nereboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fritschldwg fritschldwg merged commit a98e1fb into main Dec 8, 2023
7 checks passed
@fritschldwg fritschldwg deleted the fix/3435/fix-gh-pages-down branch December 8, 2023 10:18
@ce-bo
Copy link
Collaborator

ce-bo commented Dec 8, 2023

Do you think a second run will fix the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nereboss Nereboss Nereboss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GH-Pages down
3 participants
@fritschldwg @ce-bo @Nereboss