Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reframe sonar user token question #3445

Merged
merged 4 commits into from Dec 13, 2023

Conversation

ViktoriaGordeevaVG
Copy link
Collaborator

@ViktoriaGordeevaVG ViktoriaGordeevaVG commented Dec 12, 2023

Reframe sonar user token question

Closes: #3431

Description

  • Clarify question for sonar user token (sonar.login)

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

message = "What is the sonar.login for connecting to the remote sonar instance?",
hint = "c123d456"
message = "What is the sonar user token (sonar.login) required to connect to the remote Sonar instance?",
hint = "squ_a85eae3934941de66cbd0115f500aa59234afcda"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hint = "squ_a85eae3934941de66cbd0115f500aa59234afcda"
hint = "squ_a85eae3934941de66cbd0115f500aa59234afcda" // nosonar

Maybe this can exclude it from the security check

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest using the token:
sqp_5a03f4395033c714f44cddfabb60fe2a65fcb4bd
in the hint, as it is one used in the sonarqube documentation about tokens (https://docs.gitguardian.com/secrets-detection/detectors/specifics/sonarqube_token)
I don't know if this would fix the quality issue but I think its a good idea to use an already public token here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this token used anywhere? If yes: please change it immediately.

@fritschldwg fritschldwg force-pushed the fix/3431/reframe-sonar-login-question branch from 5822598 to 88cfe2f Compare December 13, 2023 09:29
@fritschldwg fritschldwg enabled auto-merge (rebase) December 13, 2023 12:12
Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed for 'CodeCharta Visualization'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed for 'CodeCharta Analysis'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@fritschldwg fritschldwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fritschldwg fritschldwg merged commit 7462aea into main Dec 13, 2023
7 checks passed
@fritschldwg fritschldwg deleted the fix/3431/reframe-sonar-login-question branch December 13, 2023 12:21
@fritschldwg
Copy link
Collaborator

All tokens used in the hint were either scrambled or publicly available example tokens - valid personal tokens were never introduced to the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reframe sonar.login question
5 participants