Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight nodes onclick file explorer #3488

Merged
merged 4 commits into from Feb 6, 2024
Merged

Highlight nodes onclick file explorer #3488

merged 4 commits into from Feb 6, 2024

Conversation

fritschldwg
Copy link
Collaborator

@fritschldwg fritschldwg commented Feb 5, 2024 •
edited

Highlight nodes onclick file explorer

Closes: #3470

Description

  • Highlight nodes onclick of file/folder in explorer

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

@fritschldwg fritschldwg force-pushed the feature/3470/highlight-nodes-onclick-file-explorer branch from 8b40ec4 to 9aaff37 Compare February 5, 2024 10:49
Nereboss
Nereboss approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@Nereboss Nereboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Early LGTM, can be merged after comments are applied

@fritschldwg fritschldwg enabled auto-merge (rebase) February 6, 2024 13:06
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Analysis'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Visualization'

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
92.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@fritschldwg fritschldwg merged commit 53bd0f1 into main Feb 6, 2024
7 checks passed
@fritschldwg fritschldwg deleted the feature/3470/highlight-nodes-onclick-file-explorer branch February 6, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nereboss Nereboss Nereboss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@fritschldwg @Nereboss