Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/610/helpful message if scheme doesnt match ccjson ajv #932

Merged

Conversation

RomanenkoVladimir
Copy link
Member

@RomanenkoVladimir RomanenkoVladimir commented Apr 24, 2020

Helpful Error Messages in Case of Validation Failure or API Version Discrepancy, Adressed Performance Issue

closes #610

Description

Last version changed the validation scheme from ajv to jsonscheme, resulting in major performance loss, this reintroduces ajv while keeping the error message format

Definition of Done

A task/pull request will not be considered to be complete until all these items can be checked off.

  • All requirements mentioned in the issue are implemented
  • Does match the Code of Conduct and the Contribution file
  • Task has its own GitHub issue (something it is solving)
    • Issue number is included in the commit messages for traceability
  • Update the README.md with any changes/additions made
  • Update the CHANGELOG.md with any changes/additions made
  • Enough test coverage to ensure that uncovered changes do not break functionality
  • All tests pass
  • Descriptive pull request text, answering:
    • What problem/issue are you fixing?
    • What does this PR implement and how?
  • Assign your PR to someone for a code review
    • This person will be contacted first if a bug is introduced into master
  • Manual testing did not fail

@alschmut alschmut added the pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. label Apr 24, 2020
@alschmut alschmut self-assigned this Apr 24, 2020
@alschmut alschmut merged commit e5b5e40 into master Apr 24, 2020
@alschmut alschmut deleted the feature/610/helpful-message-if-scheme-doesnt-match-ccjson-ajv branch April 24, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display a helpful message when schema of loaded cc.json does not match visualization schema
3 participants