Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with videojs player v5.00 #74

Closed
astr0junk opened this issue Oct 1, 2015 · 7 comments
Closed

Not working with videojs player v5.00 #74

astr0junk opened this issue Oct 1, 2015 · 7 comments

Comments

@astr0junk
Copy link

No description provided.

@carpasse
Copy link
Contributor

carpasse commented Oct 8, 2015

Videojs player V5.00 was officially released 9 days ago I believer.
I am going to mark this issue as enhancement. Unfortunately we currently have our hands full with new functionalities and it may take a month or two before we can give support for V5.00.

Would you be open to do it? If not we will do it but once we have implemented midroll and postroll ads. It is just more important for us right now.

@kahwee
Copy link

kahwee commented Oct 12, 2015

I can do this. How would you recommend it to be done?

The code might diverge due to ES6 enhancements.

@DrLightman
Copy link

I'm looking forward to this.

Pixels4Breakfast pushed a commit to AltitudeDigital/videojs-vast-vpaid that referenced this issue Oct 15, 2015
@vzhivkov
Copy link

kahwee's changes does help a bit but still have issues - the progress bar during the advert is not working even though on the right it shows the correct advert duration and the "rolling circle" in the center of the video doesn't hide as it should when the advert is loaded and running

@wmcmurray
Copy link
Contributor

+1

@trucle
Copy link

trucle commented Jan 5, 2016

+1

@Fetz
Copy link
Contributor

Fetz commented Jan 29, 2016

This should be working now for videojs 5x. So will close this issue

@Fetz Fetz closed this as completed Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants