XSS fix (#1255)

Mailtrain-org · May 16, 2022 · 354467b · 354467b
1 parent d005407
commit 354467b
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/client/src/login/Login.js b/client/src/login/Login.js
@@ -75,7 +75,10 @@ export default class Login extends Component {
             const submitSuccessful = await this.validateAndSendFormValuesToURL(FormSendMethod.POST, 'rest/login');
 
             if (submitSuccessful) {
-                const nextUrl = qs.parse(this.props.location.search).next || getUrl();
+                const unsafeUrl = qs.parse(this.props.location.search).next
+                const safeUrl = unsafeUrl.replace(/[^a-zA-Z0-9/\-]/g, "");
+
+                const nextUrl = safeUrl || getUrl();
 
                 /* This ensures we get config for the authenticated user */
                 window.location = nextUrl;