fix key error in dictionary #2146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request. bors try Note: if this build fails, read this. |
macdabby
commented
Jan 6, 2022
| @@ -31,7 +31,7 @@ def nginx_authentication(): | |||
| for key, value in headers.items(): | |||
| response.headers[key] = str(value) | |||
| is_valid_user = False | |||
| is_from_webmail = headers['Auth-Port'] in ['10143', '10025'] | |||
| is_from_webmail = headers.get('Auth-Port') in ['10143', '10025'] | |||
There was a problem hiding this comment.
I'll try to test this on my system, but it looks like this key is present and accessed on line #15, however on line 29 it is replaced with a dictionary from nginx.handle_authentication() which is not returning an Auth-Port key. An alternative solution would be to update that function to always return the auth port. I think that might be better, but I dont know if it was omitted for a specific reason.
tryBuild failed: |
|
Thank you for sending a PR for this; #2150 is the preferred approach for fixing it |
bors bot
added a commit
that referenced
this pull request
Jan 7, 2022
2150: fix 2145: exceptions may be thrown when login is invalid or rate-limits exceeded r=mergify[bot] a=nextgens ## What type of PR? bug-fix ## What does this PR do? Exceptions may be thrown when login is invalid or rate-limits exceeded for those running very recent builds of 1.9 For some reason I haven't caught it while testing #2130... that's when it was introduced. ### Related issue(s) - close #2145 - close #2146 - #2130 Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR?
(Feature, enhancement, bug-fix, documentation)
What does this PR do?
Related issue(s)
Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.