Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 2145: exceptions may be thrown when login is invalid or rate-limits exceeded #2150

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

nextgens
Copy link
Contributor

@nextgens nextgens commented Jan 7, 2022

What type of PR?

bug-fix

What does this PR do?

Exceptions may be thrown when login is invalid or rate-limits exceeded for those running very recent builds of 1.9

For some reason I haven't caught it while testing #2130... that's when it was introduced.

Related issue(s)

@nextgens nextgens added priority/p1 (Critical) bug with workaround / Should have type/bug Bug. Not working as intended type/backport Automatic backport this PR to the current stable release labels Jan 7, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 7, 2022

Thanks for submitting this pull request.
Bors-ng will now build test images. When it succeeds, we will continue to review and test your PR.

bors try

Note: if this build fails, read this.

@nextgens nextgens mentioned this pull request Jan 7, 2022
2 tasks
bors bot added a commit that referenced this pull request Jan 7, 2022
@bors
Copy link
Contributor

bors bot commented Jan 7, 2022

try

Build succeeded:

Copy link
Contributor

@ghostwheel42 ghostwheel42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify
Copy link
Contributor

mergify bot commented Jan 7, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 7, 2022

Build succeeded:

@bors bors bot merged commit e3e3700 into Mailu:master Jan 7, 2022
bors bot added a commit that referenced this pull request Jan 7, 2022
2152: fix 2145: exceptions may be thrown when login is invalid or rate-limits exceeded (backport #2150) r=mergify[bot] a=mergify[bot]

This is an automatic backport of pull request #2150 done by [Mergify](https://mergify.com).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the [documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- ``@Mergifyio` refresh` will re-evaluate the rules
- ``@Mergifyio` rebase` will rebase this PR on its base branch
- ``@Mergifyio` update` will merge the base branch into this PR
- ``@Mergifyio` backport <destination>` will backport this PR on `<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>


Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/p1 (Critical) bug with workaround / Should have type/backport Automatic backport this PR to the current stable release type/bug Bug. Not working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script crashing on bad auth : KeyError: 'Auth-Port'
2 participants