Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests added #8

Closed
wants to merge 12 commits into from
Closed

Tests added #8

wants to merge 12 commits into from

Conversation

TomasVotruba
Copy link
Contributor

Test status - OK: https://travis-ci.org/TomasVotruba/nette-identity-doctrine

Test suite runs for PHP 5.3-7, includes Nette 2.1, 2.2 and 2.3 (all three only for PHP 5.6, no need to test Nette for PHP versions).

(PHP 7 currently fails due to some DateTime changes.)

Among other changes:

@TomasVotruba TomasVotruba changed the title Tests added [WIP] Tests added Mar 3, 2015
@TomasVotruba TomasVotruba changed the title [WIP] Tests added Tests added Mar 3, 2015
@TomasVotruba
Copy link
Contributor Author

@Majkl578 Should be ready now. Please check.

- php: 7.0

install:
- sh -c 'if [ "$NETTE_VERSION" != "" ]; then composer require --no-update symfony/symfony=$NETTE_VERSION; fi;'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups :/

@TomasVotruba TomasVotruba changed the title Tests added [WIP] Tests added Mar 4, 2015
@TomasVotruba TomasVotruba changed the title [WIP] Tests added Tests added Mar 4, 2015
@TomasVotruba
Copy link
Contributor Author

Ok, now it's fixed (typo: evn/env).

When everything is ok, I can repush with clean commits.

Also I'd rename lib to src, since it's most used form.

@TomasVotruba
Copy link
Contributor Author

Ping @Majkl578

@Majkl578
Copy link
Owner

@TomasVotruba: Hi, thanks for your great work, I rebased it and pushed as 0d16457 + 657455a + c60283d + b9bc649 + 109c1c7. Sorry for being late to the party. :)

@Majkl578 Majkl578 closed this Jul 12, 2015
@TomasVotruba
Copy link
Contributor Author

@Majkl578 Thanks! I wonder if you still use Nette :)

@TomasVotruba TomasVotruba deleted the tests branch July 13, 2015 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants