implement isopen (#2631)

* implement isopen * Update display.jl * don't use master
MakieOrg · Jan 26, 2023 · 19a4401 · 19a4401
1 parent fa5e6b3
commit 19a4401
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/WGLMakie/src/display.jl b/WGLMakie/src/display.jl
@@ -71,6 +71,11 @@ mutable struct Screen <: Makie.MakieScreen
     end
 end
 
+function Base.isopen(screen::Screen)
+    three = get_three(screen)
+    return !isnothing(three) && isopen(three.session)
+end
+
 function mark_as_displayed!(screen::Screen, scene::Scene)
     push!(screen.displayed_scenes, js_uuid(scene))
     for child_scene in scene.children

diff --git a/metrics/ttfp/run-benchmark.jl b/metrics/ttfp/run-benchmark.jl
@@ -207,7 +207,7 @@ ENV["JULIA_PKG_PRECOMPILE_AUTO"] = 0
 project1 = make_project_folder("current-pr")
 Pkg.activate(project1)
 if Package == "WGLMakie"
-    Pkg.add([(; name="Electron"), (; name="JSServe", rev="master")])
+    Pkg.add([(; name="Electron"), (; name="JSServe")])
 end
 pkgs = NamedTuple[(; path="./MakieCore"), (; path="."), (; path="./$Package"), (;name="BenchmarkTools")]
 # cd("dev/Makie")