Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement isopen #2631

Merged
merged 4 commits into from
Jan 26, 2023
Merged

implement isopen #2631

merged 4 commits into from
Jan 26, 2023

Conversation

SimonDanisch
Copy link
Member

No description provided.

@MakieBot
Copy link
Collaborator

MakieBot commented Jan 25, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 42.45s (42.00, 42.86) 0.32+- 23.75s (23.26, 24.17) 0.36+- 22.40s (22.03, 22.71) 0.23+- 16.70ms (16.27, 17.61) 0.43+- 194.57ms (191.75, 196.43) 1.63+-
master 42.52s (42.03, 42.95) 0.34+- 23.65s (23.25, 24.09) 0.29+- 22.32s (21.76, 22.76) 0.35+- 16.50ms (16.41, 16.65) 0.09+- 194.87ms (190.69, 197.65) 2.17+-
evaluation -0.17%, -0.07s invariant (-0.22d, 0.68p, 0.33std) +0.43%, 0.1s invariant (0.31d, 0.57p, 0.33std) +0.35%, 0.08s invariant (0.27d, 0.63p, 0.29std) +1.24%, 0.21ms invariant (0.66d, 0.26p, 0.26std) -0.16%, -0.3ms invariant (-0.16d, 0.77p, 1.90std)
CairoMakie 26.14s (26.07, 26.26) 0.08+- 16.41s (16.24, 16.73) 0.17+- 2.53s (2.51, 2.55) 0.02+- 9.15ms (9.04, 9.30) 0.10+- 4.00ms (3.96, 4.17) 0.08+-
master 26.34s (26.20, 26.57) 0.13+- 16.36s (16.17, 16.52) 0.13+- 2.56s (2.52, 2.61) 0.03+- 9.05ms (8.93, 9.18) 0.08+- 4.00ms (3.95, 4.05) 0.04+-
evaluation -0.76%, -0.2s faster ✓ (-1.86d, 0.01p, 0.10std) +0.30%, 0.05s invariant (0.32d, 0.56p, 0.15std) -1.37%, -0.03s faster ✓ (-1.42d, 0.02p, 0.02std) +1.05%, 0.1ms invariant (1.09d, 0.07p, 0.09std) +0.08%, 0.0ms invariant (0.05d, 0.93p, 0.06std)
WGLMakie 46.80s (46.24, 47.63) 0.50+- 25.75s (25.26, 26.46) 0.43+- 30.41s (30.05, 31.47) 0.48+- 18.86ms (17.58, 20.17) 0.84+- 2.71s (2.51, 2.90) 0.14+-
master 47.14s (46.69, 47.47) 0.32+- 25.81s (25.36, 26.14) 0.25+- 30.16s (29.64, 30.56) 0.30+- 19.31ms (18.60, 20.03) 0.62+- 2.65s (2.48, 2.93) 0.17+-
evaluation -0.73%, -0.34s invariant (-0.82d, 0.15p, 0.41std) -0.22%, -0.06s invariant (-0.16d, 0.77p, 0.34std) +0.84%, 0.25s invariant (0.63d, 0.26p, 0.39std) -2.41%, -0.45ms invariant (-0.62d, 0.27p, 0.73std) +2.35%, 0.06s invariant (0.41d, 0.46p, 0.16std)

@SimonDanisch SimonDanisch merged commit 19a4401 into master Jan 26, 2023
@SimonDanisch SimonDanisch deleted the sd/isopen branch January 26, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants