Issue with typing on LScene with lights

[DanielVandH]

The following fails:

julia> using RPRMakie
julia> let
           fig = Figure();
           radiance = 10000
           lights = [PointLight(Vec3f(0, 0, 20), RGBf(radiance, radiance, radiance))]
           ax = LScene(fig[1, 1]; show_axis = false, scenekw=(lights=lights,))
       end
ERROR: MethodError: no method matching Scene(::Scene, ::Events, ::Observable{GeometryBasics.HyperRectangle{2, Int64}}, ::Observable{Bool}, ::Camera, ::EmptyCamera, ::Transformation, ::Vector{AbstractPlot}, ::Attributes, ::Vector{Scene}, ::Vector{MakieScreen}, ::Observable{ColorTypes.RGBA{Float32}}, ::Observable{Bool}, ::SSAO, ::Vector{PointLight})

Closest candidates are:
  Scene(::Union{Nothing, Scene}, ::Events, ::Observable{GeometryBasics.HyperRectangle{2, Int64}}, ::Observable{Bool}, ::Camera, ::AbstractCamera, ::Transformation, ::Vector{AbstractPlot}, ::Attributes, ::Vector{Scene}, ::Vector{MakieScreen}, ::Observable{ColorTypes.RGBA{Float32}}, ::Observable{Bool}, ::SSAO, ::Vector{Makie.AbstractLight})
   @ Makie C:\Users\User\.julia\packages\Makie\DekzU\src\scenes.jl:118
  Scene(::Scene, ::Any; kw...)
   @ Makie C:\Users\User\.julia\packages\Makie\DekzU\src\scenes.jl:345
  Scene(::Scene; events, px_area, clear, camera, camera_controls, transformation, kw...)
   @ Makie C:\Users\User\.julia\packages\Makie\DekzU\src\scenes.jl:303

Stacktrace:
 [1] Scene(; px_area::Observable{GeometryBasics.HyperRectangle{2, Int64}}, events::Events, clear::Observable{Bool}, transform_func::Function, camera::typeof(cam3d!), camera_controls::EmptyCamera, transformation::Transformation, plots::Vector{AbstractPlot}, children::Vector{Scene}, current_screens::Vector{MakieScreen}, parent::Scene, visible::Observable{Bool}, ssao::SSAO, lights::Vector{PointLight}, theme::Attributes, theme_kw::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
   @ Makie C:\Users\User\.julia\packages\Makie\DekzU\src\scenes.jl:253
 [2] Scene(parent::Scene; events::Events, px_area::Observable{GeometryBasics.HyperRectangle{2, Int64}}, clear::Bool, camera::Function, camera_controls::Makie.PixelCamera, transformation::Transformation, kw::Base.Pairs{Symbol, Vector{PointLight}, Tuple{Symbol}, NamedTuple{(:lights,), Tuple{Vector{PointLight}}}})
   @ Makie C:\Users\User\.julia\packages\Makie\DekzU\src\scenes.jl:318
 [3] Scene(parent::Scene, area::Observable{GeometryBasics.HyperRectangle{2, Int64}}; kw::Base.Pairs{Symbol, Any, Tuple{Symbol, Symbol, Symbol}, NamedTuple{(:clear, :camera, :lights), Tuple{Bool, typeof(cam3d!), Vector{PointLight}}}})
   @ Makie C:\Users\User\.julia\packages\Makie\DekzU\src\scenes.jl:346
 [4] initialize_block!(ls::LScene; scenekw::NamedTuple{(:lights,), Tuple{Vector{PointLight}}})
   @ Makie C:\Users\User\.julia\packages\Makie\DekzU\src\makielayout\blocks\scene.jl:23
 [5] _block(::Type{LScene}, ::Figure; bbox::Nothing, kwargs::Base.Pairs{Symbol, Any, Tuple{Symbol, Symbol}, NamedTuple{(:show_axis, :scenekw), Tuple{Bool, NamedTuple{(:lights,), Tuple{Vector{PointLight}}}}}})
   @ Makie C:\Users\User\.julia\packages\Makie\DekzU\src\makielayout\blocks.jl:374
 [6] _block(::Type{LScene}, ::GridPosition; kwargs::Base.Pairs{Symbol, Any, Tuple{Symbol, Symbol}, NamedTuple{(:show_axis, :scenekw), Tuple{Bool, NamedTuple{(:lights,), Tuple{Vector{PointLight}}}}}})
   @ Makie C:\Users\User\.julia\packages\Makie\DekzU\src\makielayout\blocks.jl:268
 [7] _block
   @ C:\Users\User\.julia\packages\Makie\DekzU\src\makielayout\blocks.jl:261 [inlined]
 [8] #_#1103
   @ C:\Users\User\.julia\packages\Makie\DekzU\src\makielayout\blocks.jl:253 [inlined]
 [9] top-level scope
   @ REPL[13]:5

since typeof(lights) == Vector{PointLight}. If instead typeof(lights) == Vector{AbstractLight}, it works:

julia> let
           fig = Figure();
           radiance = 10000
           lights = Vector{Makie.AbstractLight}([PointLight(Vec3f(0, 0, 20), RGBf(radiance, radiance, radiance))])
           ax = LScene(fig[1, 1]; show_axis = false, scenekw=(lights=lights,))
       end
LScene()

Code's taken from https://docs.makie.org/stable/documentation/backends/rprmakie/, on:

julia> versioninfo()
Julia Version 1.9.0
Commit 8e63055292 (2023-05-07 11:25 UTC)
Platform Info:
  OS: Windows (x86_64-w64-mingw32)
  CPU: 32 × 13th Gen Intel(R) Core(TM) i9-13900K
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, goldmont)
  Threads: 1 on 32 virtual cores

(jl_8jzM0Y) pkg> st
Status `C:\Users\User\AppData\Local\Temp\jl_8jzM0Y\Project.toml`
  [22d9f318] RPRMakie v0.5.5

[asinghvi17]

Yep, this is a Makie issue. Will try to patch, it's just a bad type constraint in the Scene struct definition.