New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
early attribute conversion + no proxy scene anymore -> much improved compile times #3082
Conversation
…kieOrg/Makie.jl into sd/early-attribute-conversion
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running: using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
|
Missing reference imagesFound 1 new images without existing references. |
commit 67e436d Author: SimonDanisch <sdanisch@protonmail.com> Date: Mon Jul 31 18:00:55 2023 +0200 small cleanups commit a38091f Author: SimonDanisch <sdanisch@protonmail.com> Date: Mon Jul 31 15:52:39 2023 +0200 small clean ups commit 97cfc01 Author: SimonDanisch <sdanisch@protonmail.com> Date: Thu Jul 27 16:27:04 2023 +0200 fix theming commit f31b4ab Author: SimonDanisch <sdanisch@protonmail.com> Date: Thu Jul 27 14:14:59 2023 +0200 fix WGLMakie commit 2067612 Author: SimonDanisch <sdanisch@protonmail.com> Date: Thu Jul 27 13:16:45 2023 +0200 fix WGLMakie commit 3172c6a Author: SimonDanisch <sdanisch@protonmail.com> Date: Thu Jul 27 12:48:12 2023 +0200 fix last tests commit 786c55c Author: SimonDanisch <sdanisch@protonmail.com> Date: Wed Jul 26 17:49:39 2023 +0200 try to fix cycling commit 3f2aee8 Author: SimonDanisch <sdanisch@protonmail.com> Date: Wed Jul 26 15:28:06 2023 +0200 bring back error messages commit d352d9f Author: SimonDanisch <sdanisch@protonmail.com> Date: Wed Jul 26 11:57:36 2023 +0200 fix Makie tests commit b95b72b Author: SimonDanisch <sdanisch@protonmail.com> Date: Tue Jul 25 15:40:36 2023 +0200 address frederics code review commit ee1728d Author: SimonDanisch <sdanisch@protonmail.com> Date: Tue Jul 25 15:38:51 2023 +0200 fix performance?!?! commit 22488bf Author: SimonDanisch <sdanisch@protonmail.com> Date: Mon Jul 24 18:15:39 2023 +0200 add back precompiles commit ee5e570 Author: SimonDanisch <sdanisch@protonmail.com> Date: Mon Jul 24 18:14:55 2023 +0200 fix PlotSpec commit 64576ce Author: SimonDanisch <sdanisch@protonmail.com> Date: Mon Jul 24 17:24:07 2023 +0200 fix GLMakie tests commit 0196af5 Merge: bb2f665 04f6704 Author: SimonDanisch <sdanisch@protonmail.com> Date: Mon Jul 24 11:51:25 2023 +0200 Merge branch 'master' into sd/early-attribute-conversion commit bb2f665 Author: SimonDanisch <sdanisch@protonmail.com> Date: Mon Jul 24 11:51:10 2023 +0200 dont use plotspec commit dc205a1 Author: SimonDanisch <sdanisch@protonmail.com> Date: Sat Jul 22 14:48:19 2023 +0200 fix precompilation commit 017372f Author: SimonDanisch <sdanisch@protonmail.com> Date: Sat Jul 22 13:35:21 2023 +0200 remove erroring precompiles commit 79c5294 Merge: cfeb4e6 2bdd105 Author: SimonDanisch <sdanisch@protonmail.com> Date: Sat Jul 22 12:06:49 2023 +0200 Merge branch 'sd/early-attribute-conversion' of https://github.com/MakieOrg/Makie.jl into sd/early-attribute-conversion commit cfeb4e6 Author: SimonDanisch <sdanisch@protonmail.com> Date: Sat Jul 22 12:04:47 2023 +0200 fix CairoMakie commit 2bdd105 Merge: 8d87ca7 aab593f Author: Simon <sdanisch@protonmail.com> Date: Sat Jul 22 11:38:56 2023 +0200 Merge branch 'master' into sd/early-attribute-conversion commit 8d87ca7 Author: SimonDanisch <sdanisch@protonmail.com> Date: Sat Jul 22 11:30:09 2023 +0200 fix most issues commit eb4a42d Author: SimonDanisch <sdanisch@protonmail.com> Date: Sat Jul 22 10:12:50 2023 +0200 first plot showing commit 76a3f3d Author: SimonDanisch <sdanisch@protonmail.com> Date: Sat Jul 22 09:26:14 2023 +0200 try to get things running commit d5d457c Author: SimonDanisch <sdanisch@protonmail.com> Date: Thu Jul 20 15:42:26 2023 +0200 try to get things working commit 8674156 Author: SimonDanisch <sdanisch@protonmail.com> Date: Thu Jul 20 14:03:41 2023 +0200 get code from breaking branch
commit 67e436d Author: SimonDanisch <sdanisch@protonmail.com> Date: Mon Jul 31 18:00:55 2023 +0200 small cleanups commit a38091f Author: SimonDanisch <sdanisch@protonmail.com> Date: Mon Jul 31 15:52:39 2023 +0200 small clean ups commit 97cfc01 Author: SimonDanisch <sdanisch@protonmail.com> Date: Thu Jul 27 16:27:04 2023 +0200 fix theming commit f31b4ab Author: SimonDanisch <sdanisch@protonmail.com> Date: Thu Jul 27 14:14:59 2023 +0200 fix WGLMakie commit 2067612 Author: SimonDanisch <sdanisch@protonmail.com> Date: Thu Jul 27 13:16:45 2023 +0200 fix WGLMakie commit 3172c6a Author: SimonDanisch <sdanisch@protonmail.com> Date: Thu Jul 27 12:48:12 2023 +0200 fix last tests commit 786c55c Author: SimonDanisch <sdanisch@protonmail.com> Date: Wed Jul 26 17:49:39 2023 +0200 try to fix cycling commit 3f2aee8 Author: SimonDanisch <sdanisch@protonmail.com> Date: Wed Jul 26 15:28:06 2023 +0200 bring back error messages commit d352d9f Author: SimonDanisch <sdanisch@protonmail.com> Date: Wed Jul 26 11:57:36 2023 +0200 fix Makie tests commit b95b72b Author: SimonDanisch <sdanisch@protonmail.com> Date: Tue Jul 25 15:40:36 2023 +0200 address frederics code review commit ee1728d Author: SimonDanisch <sdanisch@protonmail.com> Date: Tue Jul 25 15:38:51 2023 +0200 fix performance?!?! commit 22488bf Author: SimonDanisch <sdanisch@protonmail.com> Date: Mon Jul 24 18:15:39 2023 +0200 add back precompiles commit ee5e570 Author: SimonDanisch <sdanisch@protonmail.com> Date: Mon Jul 24 18:14:55 2023 +0200 fix PlotSpec commit 64576ce Author: SimonDanisch <sdanisch@protonmail.com> Date: Mon Jul 24 17:24:07 2023 +0200 fix GLMakie tests commit 0196af5 Merge: bb2f665 04f6704 Author: SimonDanisch <sdanisch@protonmail.com> Date: Mon Jul 24 11:51:25 2023 +0200 Merge branch 'master' into sd/early-attribute-conversion commit bb2f665 Author: SimonDanisch <sdanisch@protonmail.com> Date: Mon Jul 24 11:51:10 2023 +0200 dont use plotspec commit dc205a1 Author: SimonDanisch <sdanisch@protonmail.com> Date: Sat Jul 22 14:48:19 2023 +0200 fix precompilation commit 017372f Author: SimonDanisch <sdanisch@protonmail.com> Date: Sat Jul 22 13:35:21 2023 +0200 remove erroring precompiles commit 79c5294 Merge: cfeb4e6 2bdd105 Author: SimonDanisch <sdanisch@protonmail.com> Date: Sat Jul 22 12:06:49 2023 +0200 Merge branch 'sd/early-attribute-conversion' of https://github.com/MakieOrg/Makie.jl into sd/early-attribute-conversion commit cfeb4e6 Author: SimonDanisch <sdanisch@protonmail.com> Date: Sat Jul 22 12:04:47 2023 +0200 fix CairoMakie commit 2bdd105 Merge: 8d87ca7 aab593f Author: Simon <sdanisch@protonmail.com> Date: Sat Jul 22 11:38:56 2023 +0200 Merge branch 'master' into sd/early-attribute-conversion commit 8d87ca7 Author: SimonDanisch <sdanisch@protonmail.com> Date: Sat Jul 22 11:30:09 2023 +0200 fix most issues commit eb4a42d Author: SimonDanisch <sdanisch@protonmail.com> Date: Sat Jul 22 10:12:50 2023 +0200 first plot showing commit 76a3f3d Author: SimonDanisch <sdanisch@protonmail.com> Date: Sat Jul 22 09:26:14 2023 +0200 try to get things running commit d5d457c Author: SimonDanisch <sdanisch@protonmail.com> Date: Thu Jul 20 15:42:26 2023 +0200 try to get things working commit 8674156 Author: SimonDanisch <sdanisch@protonmail.com> Date: Thu Jul 20 14:03:41 2023 +0200 get code from breaking branch
commit 67e436d Author: SimonDanisch <sdanisch@protonmail.com> Date: Mon Jul 31 18:00:55 2023 +0200 small cleanups commit a38091f Author: SimonDanisch <sdanisch@protonmail.com> Date: Mon Jul 31 15:52:39 2023 +0200 small clean ups commit 97cfc01 Author: SimonDanisch <sdanisch@protonmail.com> Date: Thu Jul 27 16:27:04 2023 +0200 fix theming commit f31b4ab Author: SimonDanisch <sdanisch@protonmail.com> Date: Thu Jul 27 14:14:59 2023 +0200 fix WGLMakie commit 2067612 Author: SimonDanisch <sdanisch@protonmail.com> Date: Thu Jul 27 13:16:45 2023 +0200 fix WGLMakie commit 3172c6a Author: SimonDanisch <sdanisch@protonmail.com> Date: Thu Jul 27 12:48:12 2023 +0200 fix last tests commit 786c55c Author: SimonDanisch <sdanisch@protonmail.com> Date: Wed Jul 26 17:49:39 2023 +0200 try to fix cycling commit 3f2aee8 Author: SimonDanisch <sdanisch@protonmail.com> Date: Wed Jul 26 15:28:06 2023 +0200 bring back error messages commit d352d9f Author: SimonDanisch <sdanisch@protonmail.com> Date: Wed Jul 26 11:57:36 2023 +0200 fix Makie tests commit b95b72b Author: SimonDanisch <sdanisch@protonmail.com> Date: Tue Jul 25 15:40:36 2023 +0200 address frederics code review commit ee1728d Author: SimonDanisch <sdanisch@protonmail.com> Date: Tue Jul 25 15:38:51 2023 +0200 fix performance?!?! commit 22488bf Author: SimonDanisch <sdanisch@protonmail.com> Date: Mon Jul 24 18:15:39 2023 +0200 add back precompiles commit ee5e570 Author: SimonDanisch <sdanisch@protonmail.com> Date: Mon Jul 24 18:14:55 2023 +0200 fix PlotSpec commit 64576ce Author: SimonDanisch <sdanisch@protonmail.com> Date: Mon Jul 24 17:24:07 2023 +0200 fix GLMakie tests commit 0196af5 Merge: bb2f665 04f6704 Author: SimonDanisch <sdanisch@protonmail.com> Date: Mon Jul 24 11:51:25 2023 +0200 Merge branch 'master' into sd/early-attribute-conversion commit bb2f665 Author: SimonDanisch <sdanisch@protonmail.com> Date: Mon Jul 24 11:51:10 2023 +0200 dont use plotspec commit dc205a1 Author: SimonDanisch <sdanisch@protonmail.com> Date: Sat Jul 22 14:48:19 2023 +0200 fix precompilation commit 017372f Author: SimonDanisch <sdanisch@protonmail.com> Date: Sat Jul 22 13:35:21 2023 +0200 remove erroring precompiles commit 79c5294 Merge: cfeb4e6 2bdd105 Author: SimonDanisch <sdanisch@protonmail.com> Date: Sat Jul 22 12:06:49 2023 +0200 Merge branch 'sd/early-attribute-conversion' of https://github.com/MakieOrg/Makie.jl into sd/early-attribute-conversion commit cfeb4e6 Author: SimonDanisch <sdanisch@protonmail.com> Date: Sat Jul 22 12:04:47 2023 +0200 fix CairoMakie commit 2bdd105 Merge: 8d87ca7 aab593f Author: Simon <sdanisch@protonmail.com> Date: Sat Jul 22 11:38:56 2023 +0200 Merge branch 'master' into sd/early-attribute-conversion commit 8d87ca7 Author: SimonDanisch <sdanisch@protonmail.com> Date: Sat Jul 22 11:30:09 2023 +0200 fix most issues commit eb4a42d Author: SimonDanisch <sdanisch@protonmail.com> Date: Sat Jul 22 10:12:50 2023 +0200 first plot showing commit 76a3f3d Author: SimonDanisch <sdanisch@protonmail.com> Date: Sat Jul 22 09:26:14 2023 +0200 try to get things running commit d5d457c Author: SimonDanisch <sdanisch@protonmail.com> Date: Thu Jul 20 15:42:26 2023 +0200 try to get things working commit 8674156 Author: SimonDanisch <sdanisch@protonmail.com> Date: Thu Jul 20 14:03:41 2023 +0200 get code from breaking branch
Merged in #3113 |
Continues #2831 ! Still needs to check, if I rebased correctly and didn't incorrectly apply some of the changes! ## Merged PRs - #2598 - #2746 - #2346 - #2544 - #3082 - #2868 - #3062 - #3106 - #3281 - #3246 ## TODOS - [x] fix flaky test `@test GLMakie.window_size(screen.glscreen) == scaled(screen, (W, H))` - [x] Merge axis type inferences from #2220 - [x] Test on different resolution screens, IJulia, Pluto, VSCode, Windowed - [x] rebase to only have merge commits from the PRs - [x] investigate unexpected speed ups - [x] reset camera settings from tests - [ ] check doc image generation - [x] rethink default near/far in Camera3D (compatability with OIT) - [x] merge #3246 - [x] fix WGLMakie issues/tests: - [x] fix line depth issues (see tests: ~~hexbin colorrange~~ (not new), LaTeXStrings in Axis3, Axis3 axis reversal) - [x] fix lighting of surface with nan points (fixed in #3246) - ~~volume/3D contour artifacts (see 3D Contour with 2D contour slices)~~ not new - ~~artifacting in "colorscale (lines)"~~ not new - [x] GLMakie: - [x] slight outline in "scatter image markers" test - ~~clipping/z-fighting in "volume translated"~~ not new - [x] CairoMakie: - ~~Artfiacting in `colorscale (lines)"~~ not new - ~~markersize in "scatter rotations" changed?~~ not new - ~~color change in "colorscale (poly)"~~ not new - ~~transparency/render order of "OldAxis + Surface"~~ not new - ~~render order in "Merged color mesh"~~ not new - ~~render order of "Surface + wireframe + contour"~~ not new - [x] Check "SpecApi in convert_arguments" (colors swapped?) ## Fixes the following errors - fixes #2721 via #2746 - fixes #1600 via #2746 - fixes #1236 via #2746 - fixes MakieOrg/GeoMakie.jl#133 via #2598 - closes #2522 - closes #3239 via #3246 - fixes #3238 via #3246 - fixes #2985 via #3246 - fixes #3307 via #3281
This extracts useful bits from #2220, which aren't as breaking as #2220:
plot_preferred_axis
to figure out the default axis, instead of usingboundingbox(plot!(Scene(), args...))
, which is expensive and kind of hackycloses #2820