Fix #1209 #1423
Merged
Fix #1209 #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lassepe
force-pushed
the
fix/not_implemented_for_undefined
branch
from
cc50016
to
ebe45ce
Compare
|
Also, it may be good to add a test for this but I'd need a pointer where that should go. |
|
If that's something you can test after |
|
The test failures of the docs seem related. Looks like some macro hygene issue; i.e., |
|
Alright, the docs project just didn't dev MakieCore... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
not_implemented_fortoMakieCoreto fix #1209.I'm not sure if the way I imported it in
Makieis the correct/preferred way. I failed to understand the pattern that is used to organize the imports.