Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up glvisualize remnants and make mesh implementation more consistent #1654

Merged
merged 12 commits into from
Feb 11, 2022
Merged

clean up glvisualize remnants and make mesh implementation more consistent #1654

merged 12 commits into from
Feb 11, 2022

Conversation

SimonDanisch
Copy link
Member

@SimonDanisch SimonDanisch commented Feb 8, 2022 •
edited

Long overdue cleanup...
Goal of this PR is, to get rid of some ridiculus GLVisualize constructs to ease maintenance and compilation.

  • get rid of visualize
  • clean up mesh to work with nan_color etc, and fetch colormap in shader
  • fix #image by using mesh for plotting image

@SimonDanisch SimonDanisch merged commit a2ee045 into master Feb 11, 2022
@SimonDanisch SimonDanisch deleted the sd/cleanup-shader branch February 11, 2022 12:29
@IanButterworth IanButterworth mentioned this pull request May 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariusDrulea MariusDrulea MariusDrulea left review comments

Assignees
No one assigned
Labels
None yet
Projects
Compile time improvements
done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SimonDanisch @MariusDrulea