Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image contrast changed in v0.16.4 #1969

Closed
Octogonapus opened this issue May 23, 2022 · 2 comments · Fixed by #1973
Closed

Image contrast changed in v0.16.4 #1969

Octogonapus opened this issue May 23, 2022 · 2 comments · Fixed by #1973

Comments

@Octogonapus
Copy link
Contributor

Octogonapus commented May 23, 2022

The contrast of an image! plot changed in Makie v0.16.4. This also happens in v0.17. Using Julia v1.7.

MWE

import Pkg
Pkg.activate(;temp=true)
Pkg.add(name="Makie",version=ENV["MAKIE_VERSION"])
Pkg.pin(name="Makie",version=ENV["MAKIE_VERSION"])
Pkg.add(name="GLMakie")
Pkg.add(name="FileIO")

using GLMakie, FileIO

f = Figure(resolution=(100,100))
ax = Axis(f)
img = reshape([UInt8(i+j) for j in 1:10 for i in 1:40], (40,10))
image!(ax, img, interpolate = false, colorrange = (0, 255))
FileIO.save(joinpath(@__DIR__, "$(ENV["MAKIE_VERSION"])_img.png"), f)

Makie v0.16.3 (correct):
0 16 3_img

Makie v0.16.4 (incorrect; image is different):
0 16 4_img

Makie v0.17.3 (also incorrect):
0 17 3_img

@IanButterworth
Copy link
Contributor

Seems likely that the regression was in #1654

Any idea @SimonDanisch? This is pinning us to v0.16.3

@SimonDanisch
Copy link
Member

I can take a look tomorrow!

SimonDanisch added a commit that referenced this issue May 25, 2022
* fix #1969, interpolate cmap correctly

* this wasn't needed

* add tests for colormap interpolation

* clean up unused functions

* fix WGLMakie & use @ffreyer s fix

* fix variable names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants