Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1969, interpolate cmap correctly #1973

Merged
merged 6 commits into from May 25, 2022
Merged

Conversation

SimonDanisch
Copy link
Member

This is really weird, I don't see any reason why texture(cmap, val01) should do incorrect interpolations when only having few colors in the colormap (e.g. like with the default one for image which is [:black, :white]).
Would be nice to figure out the exact bug here, but meanwhile this should fix it.
I also deleted the GLVisualize remnant of having a stroke_width for the heatmap.. This isn't used nor tested and only implemented in GLMakie. I feel like we should either support it fully, or just don't offer it.
If this makes it a breaking change, I may also just bring it back 馃し
Fixes #1969

@MakieBot
Copy link
Collaborator

MakieBot commented May 24, 2022

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt.

using time

master:  12.16 < 12.64 > 12.84, 0.25+-
pr:      12.34 < 12.57 > 13.15, 0.31+-
speedup: 0.95 < 0.98 > 1.02, 0.03+-
median:  -0.49% => invariant

This PR does not change the using time.

ttfp time

master   31.67 < 31.80 > 32.94, 0.46+-
pr       31.07 < 31.90 > 33.03, 0.71+-
speedup: 0.97 < 1.01 > 1.03, 0.02+-
median:  +0.31% => invariant

This PR does not change the ttfp time.

@SimonDanisch
Copy link
Member Author

Before:
image
This PR:
image

@SimonDanisch SimonDanisch merged commit ef92c4b into master May 25, 2022
@SimonDanisch SimonDanisch deleted the sd/fix-interpolation branch May 25, 2022 09:48
@IanButterworth
Copy link
Contributor

Nice! Thanks 馃檹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image contrast changed in v0.16.4
3 participants