fix #1969, interpolate cmap correctly #1973
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is really weird, I don't see any reason why
texture(cmap, val01)
should do incorrect interpolations when only having few colors in the colormap (e.g. like with the default one forimage
which is[:black, :white]
).Would be nice to figure out the exact bug here, but meanwhile this should fix it.
I also deleted the GLVisualize remnant of having a
stroke_width
for the heatmap.. This isn't used nor tested and only implemented in GLMakie. I feel like we should either support it fully, or just don't offer it.If this makes it a breaking change, I may also just bring it back 馃し
Fixes #1969