Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move poly to MakieCore #2334

Merged
merged 3 commits into from Oct 21, 2022
Merged

move poly to MakieCore #2334

merged 3 commits into from Oct 21, 2022

Conversation

jw3126
Copy link
Contributor

@jw3126 jw3126 commented Oct 13, 2022

@jw3126 jw3126 closed this Oct 13, 2022
@jw3126 jw3126 reopened this Oct 13, 2022
@jw3126
Copy link
Contributor Author

jw3126 commented Oct 20, 2022

Bump! Is there some arguments against this? Would be really helpful for us to have lightweight access to poly.

@SimonDanisch
Copy link
Member

Yes, thank you, I think this is a good idea, although it's not really clear on where to draw the line... But lets just merge this for now, if it helps your use case! :)

@SimonDanisch SimonDanisch merged commit 853d17e into MakieOrg:master Oct 21, 2022
@jw3126
Copy link
Contributor Author

jw3126 commented Oct 21, 2022

@SimonDanisch thanks for merging! What are the downsides of declaring more polytypes in MakieCore?

@jkrumbiegel
Copy link
Collaborator

it's just that makiecore is supposed to be lightweight, and the more we add the less it is that

@SimonDanisch
Copy link
Member

Also we really want to start having a "real" solution, where you can just address any plot/recipe without taking on the dependency ;)

@jw3126
Copy link
Contributor Author

jw3126 commented Oct 21, 2022

Also we really want to start having a "real" solution, where you can just address any plot/recipe without taking on the dependency ;)

Sounds awesome!

@jw3126
Copy link
Contributor Author

jw3126 commented Oct 21, 2022

it's just that makiecore is supposed to be lightweight, and the more we add the less it is that

But do @recipe calls make the package more heavy weight? I am not talking about moving any implementations to MakieCore. Just adding more "some docs" @recipe(...) to MakieCore.

@SimonDanisch
Copy link
Member

I don't really think it matters in this case, and won't for a couple more, as long as we don't need further package dependencies. It'll just a bit random, which recipes make it into the exclusive MakieCore club ;)

@jw3126
Copy link
Contributor Author

jw3126 commented Oct 22, 2022

Can we have a MakieCore release? Should I bump the version?

t-bltg pushed a commit to t-bltg/Makie.jl that referenced this pull request Dec 31, 2022
* move poly to MakieCore

* improve poly docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants