move Arrows and Wireframe to MakieCore #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jw3126
commented
Oct 29, 2022
| @@ -21,31 +21,12 @@ grid. | |||
| ## Attributes | |||
| $(ATTRIBUTES) | |||
| """ | |||
There was a problem hiding this comment.
In this PR I kept the docs in Makie.jl.
The advantage is that the docstring extensions machinery is avaible in Makie but not in MakieCore.
The only observable difference is that before arrows and arrows! had exactly the same doc string. After this PR the arrows docstring stays the same, but arrows! docstring just says "see arrows".
|
Thanks, seems fair to move those too🤷♂️ |
|
Should we just move all of them? |
My opinion is that every recipe that does not add dependencies to MakieCore should be declared there. |
t-bltg
pushed a commit
to t-bltg/Makie.jl
that referenced
this pull request
Dec 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kind of a follow-up to:
#2334