Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.19.1 #2540

Merged
merged 2 commits into from
Jan 1, 2023
Merged

v0.19.1 #2540

merged 2 commits into from
Jan 1, 2023

Conversation

SimonDanisch
Copy link
Member

Description

Fixes # (issue)

Add a description of your PR here.

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@SimonDanisch SimonDanisch marked this pull request as ready for review January 1, 2023 21:04
@SimonDanisch SimonDanisch merged commit 14d06c0 into master Jan 1, 2023
@SimonDanisch SimonDanisch deleted the sd/v19.1 branch January 1, 2023 21:04
@MakieBot
Copy link
Collaborator

MakieBot commented Jan 1, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 41.15s (40.19, 42.66) 0.92+- 21.92s (21.54, 22.72) 0.39+- 20.72s (20.20, 21.90) 0.62+- 18.43ms (18.15, 18.60) 0.15+- 195.14ms (189.90, 200.51) 3.19+-
master 41.57s (40.13, 45.42) 1.86+- 22.24s (21.39, 24.15) 0.97+- 20.61s (20.00, 21.55) 0.58+- 18.68ms (18.23, 19.09) 0.34+- 196.40ms (194.87, 200.46) 1.90+-
evaluation -1.01%, -0.42s invariant (-0.28d, 0.61p, 1.39std) -1.45%, -0.32s invariant (-0.43d, 0.44p, 0.68std) +0.54%, 0.11s invariant (0.19d, 0.73p, 0.60std) -1.35%, -0.25ms invariant (-0.94d, 0.12p, 0.25std) -0.65%, -1.26ms invariant (-0.48d, 0.39p, 2.54std)
CairoMakie 27.58s (27.29, 27.80) 0.20+- 16.45s (16.09, 16.77) 0.23+- 2.56s (2.53, 2.59) 0.03+- 11.43ms (11.11, 11.71) 0.19+- 4.62ms (4.51, 4.79) 0.11+-
master 27.65s (27.29, 27.93) 0.25+- 16.49s (16.20, 16.81) 0.24+- 2.57s (2.51, 2.65) 0.05+- 11.34ms (11.14, 11.59) 0.19+- 4.57ms (4.42, 4.70) 0.09+-
evaluation -0.25%, -0.07s invariant (-0.31d, 0.57p, 0.22std) -0.25%, -0.04s invariant (-0.18d, 0.75p, 0.24std) -0.40%, -0.01s invariant (-0.26d, 0.64p, 0.04std) +0.79%, 0.09ms invariant (0.47d, 0.40p, 0.19std) +1.10%, 0.05ms invariant (0.50d, 0.36p, 0.10std)
WGLMakie
master
evaluation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants