Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call normalize with qualified name #2740

Merged
merged 3 commits into from
Mar 15, 2023
Merged

Call normalize with qualified name #2740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74b06e1
Call normalize with qualified name
steffenhaug Mar 9, 2023
022de7f
Merge branch 'master' into fix-normalize-arrowplot
asinghvi17 Mar 15, 2023
b641f0f
Update NEWS.md
asinghvi17 Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- Fixed issue with scatterlines only accepting concrete color types as `markercolor` [#2691](https://github.com/MakieOrg/Makie.jl/pull/2691)
- Fixed an accidental issue where `LaTeXStrings` were not typeset correctly in `Axis3`. [#2558](https://github.com/MakieOrg/Makie.jl/pull/2588)
- Fixed a bug where line segments in `text(lstr::LaTeXString)` were ignoring offsets. [#2668](https://github.com/MakieOrg/Makie.jl/pull/2668)
- Fixed a bug where the `arrows` recipe accidentally called a `Bool` when `normalize = true`. [#2740](https://github.com/MakieOrg/Makie.jl/pull/2740)
- Re-exported the `@colorant_str` (`colorant"..."`) macro from Colors.jl. [#2726](https://github.com/MakieOrg/Makie.jl/pull/2726)

## v0.19.1
Expand Down
2 changes: 1 addition & 1 deletion src/basic_recipes/arrows.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ function plot!(arrowplot::Arrows{<: Tuple{AbstractVector{<: Point{N}}, V}}) wher
fxaa_bool = @lift($fxaa == automatic ? false : $fxaa)
headstart = lift(points, directions, normalize, align, lengthscale) do points, dirs, n, align, s
map(points, dirs) do p1, dir
dir = n ? normalize(dir) : dir
dir = n ? LinearAlgebra.normalize(dir) : dir
if align in (:head, :lineend, :tailend, :headstart, :center)
shift = s .* dir
else
Expand Down