Call normalize with qualified name #2740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't really understand the details of this check failing. I ran the test suite locally with Julia 1.8 and have tested making normalized arrow plots with all three backends. Is this check testing with Julia 1.0, and is that expected to work? I guess what I want to know is, is there anything I should do now to get this in shape to merge? |
|
No this failure isn't related to your change.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2738
Qualifies the call to
normalizewithLinearAlgebrato avoid name clash with the@extracted parameter of the same name.Type of change
In the past it was qualified with
StaticArrays, however that is no longer a dependency of the library apparently which is probably why it was changed to break in the first place. TheStaticArraysone is just a reexport of theLinearAlgebraone anyways as far as I can tell, so this should be identical to the old behavior.Do you usually make tests for things like this? I'm not familiar enough with the internals of Makie yet to know how to verify programmatically that the data on the plot has actually been normalized, however I tested the fix on my use case and it works both in CairoMakie and GLMakie. If you want a test I can probably look into it with some help.