-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up list of available formats #3020
Conversation
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running: using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
|
We still support JPG though! |
Really? I remember removing conversions for that a long time ago in CairoMakie |
Yup, we have a fallback in Makie.jl :D |
Should we only remove bmp and leave jpg for now? |
Maybe I'm pedantic in that way, but jpg is just not a good format for thin lines etc., we all know what the block artifacts look like. So I'm not really for keeping it. bmp is ok but just makes huge files. |
Well, we don't only offer thin line plots, and it's basically free to offer jpg... So I don't see the harm ;) |
Yeah, either way, it doesn't matter that much |
Removes formats we don't support (anymore).