Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up list of available formats #3020

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Clean up list of available formats #3020

merged 2 commits into from
Jul 18, 2023

Conversation

jkrumbiegel
Copy link
Member

Removes formats we don't support (anymore).

@MakieBot
Copy link
Collaborator

MakieBot commented Jun 21, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 12.37s (12.20, 12.60) 0.14+- 1.18s (1.15, 1.22) 0.02+- 839.10ms (814.95, 865.50) 17.45+- 11.38ms (11.13, 11.77) 0.19+- 92.96ms (91.99, 95.81) 1.35+-
master 12.40s (12.21, 12.67) 0.16+- 1.17s (1.14, 1.20) 0.02+- 815.28ms (803.03, 829.69) 9.08+- 11.45ms (11.26, 11.70) 0.19+- 93.10ms (92.10, 95.37) 1.10+-
evaluation -0.19%, -0.02s invariant (-0.16d, 0.77p, 0.15std) +0.76%, 0.01s invariant (0.40d, 0.47p, 0.02std) +2.84%, 23.82ms slower X (1.71d, 0.01p, 13.27std) -0.69%, -0.08ms invariant (-0.41d, 0.46p, 0.19std) -0.15%, -0.14ms invariant (-0.11d, 0.84p, 1.22std)
CairoMakie 12.61s (12.01, 12.90) 0.31+- 1.53s (1.45, 1.57) 0.04+- 309.61ms (285.58, 338.92) 15.81+- 14.59ms (13.87, 15.32) 0.48+- 7.89ms (7.47, 8.25) 0.24+-
master 12.66s (12.52, 12.89) 0.13+- 1.55s (1.53, 1.58) 0.02+- 294.50ms (285.70, 306.61) 7.49+- 14.75ms (14.36, 15.21) 0.31+- 7.84ms (7.59, 7.96) 0.13+-
evaluation -0.36%, -0.04s invariant (-0.19d, 0.73p, 0.22std) -1.30%, -0.02s invariant (-0.62d, 0.28p, 0.03std) +4.88%, 15.11ms slower X (1.22d, 0.05p, 11.65std) -1.07%, -0.16ms invariant (-0.38d, 0.49p, 0.40std) +0.63%, 0.05ms invariant (0.26d, 0.64p, 0.18std)
WGLMakie 14.24s (13.93, 14.59) 0.23+- 1.60s (1.52, 1.66) 0.05+- 13.50s (13.07, 13.91) 0.33+- 21.61ms (20.42, 23.43) 1.17+- 1.30s (1.22, 1.34) 0.05+-
master 14.27s (14.12, 14.57) 0.20+- 1.55s (1.50, 1.59) 0.03+- 13.77s (13.31, 14.24) 0.37+- 21.71ms (20.77, 22.89) 0.73+- 1.33s (1.28, 1.46) 0.07+-
evaluation -0.22%, -0.03s invariant (-0.14d, 0.79p, 0.21std) +2.98%, 0.05s invariant (1.16d, 0.06p, 0.04std) -2.00%, -0.27s invariant (-0.77d, 0.17p, 0.35std) -0.43%, -0.09ms invariant (-0.10d, 0.86p, 0.95std) -2.30%, -0.03s invariant (-0.52d, 0.35p, 0.06std)

@SimonDanisch
Copy link
Member

We still support JPG though!

@jkrumbiegel
Copy link
Member Author

Really? I remember removing conversions for that a long time ago in CairoMakie

@SimonDanisch
Copy link
Member

Yup, we have a fallback in Makie.jl :D

@SimonDanisch
Copy link
Member

Should we only remove bmp and leave jpg for now?

@jkrumbiegel
Copy link
Member Author

Maybe I'm pedantic in that way, but jpg is just not a good format for thin lines etc., we all know what the block artifacts look like. So I'm not really for keeping it. bmp is ok but just makes huge files.

@SimonDanisch
Copy link
Member

Well, we don't only offer thin line plots, and it's basically free to offer jpg... So I don't see the harm ;)
But I guess anyone can still do save("plot.jpg", colorbuffer(fig)), so, i guess it could be ok to remove it entirely...

@jkrumbiegel
Copy link
Member Author

Yeah, either way, it doesn't matter that much

@jkrumbiegel jkrumbiegel merged commit 12dd058 into master Jul 18, 2023
13 checks passed
@jkrumbiegel jkrumbiegel deleted the jkrumbiegel-patch-1 branch July 18, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants