Sf/vscode resizing #3044
Sf/vscode resizing #3044
Conversation
This implements basic resizing support for WGLMakie figures. This has primarily been tested in the VSCode plot pane and the JSServe auto-launched browser window (using Chrome and Safari). The implementation creates a new `resize` event that the javascript frontend can send back to the Julia backend, with a computed size (in pixels) that the backend should resize to. Additionally, the javascript `throttle()` function is altered to no longer drop the last few events when throttled, it instead delays the last event until the end of the throttling period, which is important when resizing quickly so that the final size is faithfully recorded.
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running: using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
|
And test if CI hangs like in #3044
And test if CI hangs like in #3044
|
FTR, I think this is approach is fine. I just put |
|
@kbarros, the aspect ratio for LScene should be fixed now! (btw, you need to do |
|
I can confirm the aspect ratio bug has been fixed and with this branch, resizing now works as intended! If I may request a future feature: Can resizing take into account the width of the panel? See for example the two attached VSCode images. Changing the width of the panel will not enlarge or shrink the image size. 
This behavior is shared by GLMakie pop-up windows. In GLMakie, it's fine. However, "tall and narrow" panels seem to appear by default in VSCode. The image below shows the behaviors of a Plots.jl image that resizes according to the panel width inside VSCode. 
Interestingly, the Plots.jl image ignores the panel height (so it's the converse of Makie). I wonder if an ideal behavior is to use something like |
I agree that locking to the minimum dimension is likely the ideal solution, but should probably be implemented in a follow-on PR. |
|
Also good to keep in mind that Jupyter notebooks tend to have short wide panels -- so we can't only look at the panel width in that use case. |
|
Actually, I accidently achieved the plots.jl behaviour by using the wrappers div function resize_callback() {
comm.notify({ resize: [wrapper.offsetWidth, wrapper.offsetHeight] });
} |
|
Interesting. I'd be happy to test that change in VSCode and Jupyter if you put it on a branch. |
Continue #3042 and make it optional!