Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resizing to width #3056

Closed
wants to merge 1 commit into from
Closed

Conversation

SimonDanisch
Copy link
Member

@SimonDanisch SimonDanisch changed the base branch from master to sf/vscode_resizing July 10, 2023 16:35
@SimonDanisch SimonDanisch mentioned this pull request Jul 10, 2023
@kbarros
Copy link
Contributor

kbarros commented Jul 10, 2023

For me, this one isn't working well. The rendered image is not expanding with the width or height of the panel. Below shows a widened panel with no enlargement of the WGL viewport.

image

Also, there is a bug where if I shrink the height of the panel and reexpand, the image totally disappears.

@MakieBot
Copy link
Collaborator

MakieBot commented Jul 10, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 12.01s (11.88, 12.18) 0.12+- 1.14s (1.12, 1.16) 0.02+- 812.05ms (781.52, 857.45) 24.66+- 10.90ms (10.73, 11.03) 0.12+- 90.92ms (90.16, 92.02) 0.62+-
master 12.01s (11.96, 12.17) 0.07+- 1.14s (1.13, 1.16) 0.01+- 798.68ms (785.62, 819.35) 10.89+- 10.93ms (10.78, 11.08) 0.12+- 90.76ms (89.12, 92.26) 0.94+-
evaluation +0.01%, 0.0s invariant (0.02d, 0.97p, 0.10std) -0.22%, -0.0s invariant (-0.18d, 0.74p, 0.01std) +1.65%, 13.37ms invariant (0.70d, 0.22p, 17.77std) -0.24%, -0.03ms invariant (-0.21d, 0.69p, 0.12std) +0.18%, 0.16ms invariant (0.20d, 0.71p, 0.78std)
CairoMakie 9.74s (9.64, 9.91) 0.09+- 1.19s (1.18, 1.21) 0.01+- 250.55ms (246.59, 257.77) 3.86+- 10.03ms (9.84, 10.26) 0.13+- 5.69ms (5.55, 5.78) 0.10+-
master 9.71s (9.64, 9.79) 0.05+- 1.20s (1.18, 1.21) 0.01+- 239.65ms (235.36, 246.67) 3.77+- 9.99ms (9.89, 10.15) 0.10+- 5.70ms (5.64, 5.80) 0.06+-
evaluation +0.36%, 0.03s invariant (0.46d, 0.41p, 0.07std) -0.32%, -0.0s invariant (-0.42d, 0.44p, 0.01std) +4.35%, 10.9ms slower X (2.86d, 0.00p, 3.81std) +0.36%, 0.04ms invariant (0.31d, 0.57p, 0.11std) -0.24%, -0.01ms invariant (-0.16d, 0.77p, 0.08std)
WGLMakie 13.30s (13.05, 13.48) 0.15+- 1.37s (1.35, 1.40) 0.02+- 11.88s (11.74, 11.96) 0.08+- 17.24ms (15.13, 25.87) 3.85+- 1.21s (1.18, 1.25) 0.02+-
master 13.36s (13.13, 13.48) 0.12+- 1.39s (1.36, 1.44) 0.03+- 11.94s (11.82, 12.11) 0.09+- 15.56ms (14.20, 17.02) 0.88+- 1.18s (1.15, 1.25) 0.03+-
evaluation -0.47%, -0.06s invariant (-0.46d, 0.40p, 0.13std) -1.30%, -0.02s invariant (-0.69d, 0.23p, 0.03std) -0.52%, -0.06s invariant (-0.71d, 0.21p, 0.09std) +9.76%, 1.68ms noisy🤷‍♀️ (0.60d, 0.30p, 2.37std) +2.60%, 0.03s invariant (1.07d, 0.07p, 0.03std)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants