Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for 0.20 release #3401

Merged
merged 3 commits into from Nov 23, 2023
Merged

Fixes for 0.20 release #3401

merged 3 commits into from Nov 23, 2023

Conversation

SimonDanisch
Copy link
Member

@MakieBot
Copy link
Collaborator

MakieBot commented Nov 23, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 3.36s (3.32, 3.39) 0.02+- 514.07ms (507.72, 521.83) 5.26+- 481.27ms (471.30, 520.38) 17.42+- 7.45ms (7.35, 7.52) 0.05+- 25.51ms (25.41, 25.63) 0.09+-
master 3.38s (3.37, 3.43) 0.02+- 495.44ms (319.29, 527.67) 77.78+- 474.33ms (465.42, 483.18) 5.98+- 7.47ms (7.41, 7.51) 0.04+- 25.50ms (25.42, 25.76) 0.12+-
evaluation 1.01x invariant, -0.02s (-0.96d, 0.10p, 0.02std) 0.96x invariant, 18.62ms (0.34d, 0.55p, 41.52std) 0.99x invariant, 6.93ms (0.53d, 0.35p, 11.70std) 1.00x invariant, -0.03ms (-0.58d, 0.30p, 0.04std) 1.00x invariant, 0.01ms (0.11d, 0.84p, 0.10std)
CairoMakie 2.81s (2.76, 2.93) 0.06+- 323.03ms (313.56, 341.85) 11.12+- 143.21ms (139.64, 151.30) 4.54+- 7.40ms (7.27, 7.72) 0.16+- 619.50μs (607.63, 629.34) 8.24+-
master 2.82s (2.80, 2.88) 0.03+- 331.72ms (326.12, 343.73) 5.78+- 142.25ms (139.98, 145.94) 1.90+- 7.43ms (7.27, 7.63) 0.14+- 618.53μs (605.80, 637.03) 9.61+-
evaluation 1.01x invariant, -0.01s (-0.31d, 0.57p, 0.04std) 1.03x invariant, -8.69ms (-0.98d, 0.10p, 8.45std) 0.99x invariant, 0.95ms (0.27d, 0.62p, 3.22std) 1.00x invariant, -0.03ms (-0.20d, 0.71p, 0.15std) 1.00x invariant, 0.97μs (0.11d, 0.84p, 8.92std)
WGLMakie 3.59s (3.49, 3.73) 0.07+- 527.03ms (513.54, 541.53) 11.49+- 8.70s (8.45, 9.04) 0.20+- 9.84ms (9.49, 10.26) 0.29+- 72.46ms (67.98, 78.77) 4.46+-
master 3.57s (3.51, 3.73) 0.08+- 540.35ms (522.16, 570.00) 20.01+- 8.59s (8.46, 8.82) 0.13+- 9.77ms (9.23, 11.61) 0.83+- 73.19ms (67.92, 80.66) 4.06+-
evaluation 0.99x invariant, 0.02s (0.25d, 0.65p, 0.08std) 1.03x invariant, -13.32ms (-0.82d, 0.16p, 15.75std) 0.99x invariant, 0.11s (0.66d, 0.24p, 0.16std) 0.99x invariant, 0.07ms (0.11d, 0.84p, 0.56std) 1.01x invariant, -0.73ms (-0.17d, 0.76p, 4.26std)

@SimonDanisch SimonDanisch merged commit b34d455 into master Nov 23, 2023
15 checks passed
@SimonDanisch SimonDanisch deleted the sd/hot-fixes branch November 23, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plotting into an existing axis throws on v0.20.0
2 participants