Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pkg extension #90

Merged
merged 8 commits into from Nov 24, 2023
Merged

fix pkg extension #90

merged 8 commits into from Nov 24, 2023

Conversation

Moelf
Copy link
Owner

@Moelf Moelf commented Nov 22, 2023

@jjgomezcadenas I think we need ./ext/ for this to work

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (cd02d1a) 82.02% compared to head (8c6b035) 82.57%.

Files Patch % Lines
ext/FHistMakieExt.jl 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   82.02%   82.57%   +0.54%     
==========================================
  Files          10        9       -1     
  Lines         751      746       -5     
==========================================
  Hits          616      616              
+ Misses        135      130       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Moelf
Copy link
Owner Author

Moelf commented Nov 23, 2023

We will release once the following PR is made into a makie release

@jjgomezcadenas
Copy link
Contributor

Hi, I see the ext code (not quite get the logic why ithe code should be in ext). The notebook still fails.

@Moelf
Copy link
Owner Author

Moelf commented Nov 23, 2023

Because according to the Pkg doc it must be in ext/

Yea cuz the Makie 0.20.1 was not released, let me re trigger

@Moelf
Copy link
Owner Author

Moelf commented Nov 23, 2023

Ok that worked, now Documenter.jl error

@Moelf Moelf merged commit c17415f into main Nov 24, 2023
6 of 7 checks passed
@Moelf Moelf deleted the fix_extention branch November 24, 2023 00:36
This was referenced Nov 24, 2023
@Moelf Moelf changed the title fix pkg extention fix pkg extension Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants