New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix pkg extension #90
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 82.02% 82.57% +0.54%
==========================================
Files 10 9 -1
Lines 751 746 -5
==========================================
Hits 616 616
+ Misses 135 130 -5 ☔ View full report in Codecov by Sentry. |
We will release once the following PR is made into a makie release |
Hi, I see the ext code (not quite get the logic why ithe code should be in ext). The notebook still fails. |
Because according to the Pkg doc it must be in ext/ Yea cuz the Makie 0.20.1 was not released, let me re trigger |
Ok that worked, now Documenter.jl error |
@jjgomezcadenas I think we need
./ext/
for this to work