Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix position of mirrored ticks when single dimension updates #3581

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

jkrumbiegel
Copy link
Member

Fixes #3579

Might be that with this the update structure is not ideal, but that could be fixed later if it turns out to be an issue. More important is that the ticks are not wrongly positioned.

@MakieBot
Copy link
Collaborator

MakieBot commented Jan 31, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 3.41s (3.39, 3.41) 0.01+- 379.75ms (374.04, 381.91) 2.80+- 465.32ms (461.64, 471.53) 3.29+- 7.10ms (7.06, 7.29) 0.08+- 25.35ms (25.31, 25.40) 0.03+-
master 3.39s (3.36, 3.41) 0.02+- 364.26ms (304.14, 394.06) 40.53+- 471.01ms (461.44, 514.39) 19.21+- 7.07ms (7.03, 7.16) 0.04+- 25.32ms (25.23, 25.40) 0.06+-
evaluation 1.00x invariant, 0.02s (0.98d, 0.10p, 0.02std) 0.96x invariant, 15.49ms (0.54d, 0.35p, 21.66std) 1.01x invariant, -5.68ms (-0.41d, 0.47p, 11.25std) 1.00x invariant, 0.03ms (0.47d, 0.40p, 0.06std) 1.00x invariant, 0.03ms (0.57d, 0.31p, 0.05std)
CairoMakie 3.15s (3.11, 3.23) 0.04+- 333.70ms (326.50, 349.89) 8.11+- 146.55ms (143.81, 151.71) 2.98+- 7.47ms (7.34, 7.56) 0.08+- 606.20μs (601.97, 614.37) 3.90+-
master 3.11s (3.08, 3.13) 0.02+- 330.25ms (325.66, 335.15) 3.72+- 142.95ms (138.96, 144.80) 1.95+- 7.44ms (7.31, 7.56) 0.09+- 607.41μs (603.86, 610.66) 2.19+-
evaluation 0.99x invariant, 0.04s (1.12d, 0.07p, 0.03std) 0.99x invariant, 3.45ms (0.55d, 0.33p, 5.91std) 0.98x slower X, 3.59ms (1.43d, 0.02p, 2.46std) 1.00x invariant, 0.03ms (0.31d, 0.58p, 0.09std) 1.00x invariant, -1.21μs (-0.38d, 0.49p, 3.05std)
WGLMakie 3.73s (3.71, 3.75) 0.02+- 328.11ms (320.27, 348.37) 9.94+- 9.09s (8.89, 9.46) 0.20+- 9.78ms (9.04, 13.13) 1.48+- 72.78ms (68.80, 79.21) 4.53+-
master 3.71s (3.68, 3.75) 0.03+- 324.73ms (321.96, 327.14) 1.87+- 8.89s (8.79, 8.96) 0.07+- 9.14ms (9.07, 9.19) 0.05+- 73.16ms (68.07, 78.45) 4.70+-
evaluation 1.00x invariant, 0.01s (0.60d, 0.29p, 0.02std) 0.99x invariant, 3.37ms (0.47d, 0.41p, 5.90std) 0.98x slower X, 0.2s (1.31d, 0.04p, 0.13std) 0.93x noisy🤷‍♀️, 0.64ms (0.61d, 0.30p, 0.77std) 1.01x invariant, -0.38ms (-0.08d, 0.88p, 4.62std)

@jkrumbiegel jkrumbiegel merged commit 14528a1 into master Jan 31, 2024
17 checks passed
@jkrumbiegel jkrumbiegel deleted the jk/fix-mirrored-tick-positions branch January 31, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Right ticks of an Axis not updating correctly when adding a Colorbar
2 participants