Use label formatter in barplot. #3718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, when the labels were not just the `:x` or `:y` symbols, the label formatter wasn't applied.
|
Thanks! merged in #3721 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before, when the labels were not just the
:xor:ysymbols, the label formatter wasn't applied.Now we apply it, but have to be careful to dispatch the default formatter depending on the input type.
In the PR I define new dispatches for
::Stringand::LaTeXStringtypes (basically the identity function), which should also fix the failing tests.Type of change
Basically just change a typo and add two dispatches.
Delete options that do not apply:
Fixes #3720.