Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use label formatter in barplot #3721

Merged
merged 5 commits into from Mar 19, 2024
Merged

Use label formatter in barplot #3721

merged 5 commits into from Mar 19, 2024

Conversation

SimonDanisch
Copy link
Member

Fix for #3718

@MakieBot
Copy link
Collaborator

MakieBot commented Mar 19, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 3.31s (3.28, 3.33) 0.02+- 162.78ms (161.98, 163.60) 0.56+- 466.01ms (463.88, 468.91) 1.83+- 7.17ms (7.12, 7.24) 0.04+- 25.44ms (25.38, 25.58) 0.07+-
master 3.31s (3.28, 3.34) 0.02+- 164.14ms (161.50, 166.82) 1.87+- 468.22ms (463.83, 479.04) 5.05+- 7.28ms (7.13, 7.47) 0.10+- 25.49ms (25.37, 25.66) 0.12+-
evaluation 1.00x invariant, -0.0s (-0.08d, 0.88p, 0.02std) 1.01x invariant, -1.36ms (-0.99d, 0.11p, 1.21std) 1.00x invariant, -2.21ms (-0.58d, 0.31p, 3.44std) 1.02x faster ✓, -0.11ms (-1.43d, 0.03p, 0.07std) 1.00x invariant, -0.05ms (-0.55d, 0.33p, 0.09std)
CairoMakie 2.93s (2.91, 2.95) 0.01+- 163.75ms (162.73, 164.71) 0.89+- 100.17ms (99.22, 101.29) 0.84+- 7.23ms (7.20, 7.28) 0.03+- 894.80μs (884.52, 901.62) 6.36+-
master 2.94s (2.90, 2.98) 0.02+- 163.54ms (161.01, 167.53) 2.33+- 99.70ms (98.16, 101.41) 1.17+- 7.04ms (7.00, 7.07) 0.02+- 879.98μs (874.73, 886.06) 4.34+-
evaluation 1.00x invariant, -0.01s (-0.27d, 0.62p, 0.02std) 1.00x invariant, 0.21ms (0.12d, 0.83p, 1.61std) 1.00x invariant, 0.47ms (0.46d, 0.41p, 1.01std) 0.97x slower X, 0.2ms (7.03d, 0.00p, 0.03std) 0.98x slower X, 14.81μs (2.72d, 0.00p, 5.35std)
WGLMakie 3.52s (3.50, 3.54) 0.01+- 370.59ms (365.82, 384.79) 6.64+- 8.39s (8.30, 8.46) 0.05+- 9.35ms (8.97, 11.34) 0.88+- 68.46ms (67.50, 69.29) 0.65+-
master 3.52s (3.50, 3.56) 0.02+- 280.24ms (162.36, 369.28) 109.12+- 8.50s (8.37, 8.64) 0.11+- 9.12ms (9.06, 9.21) 0.05+- 68.03ms (67.20, 69.09) 0.66+-
evaluation 1.00x invariant, -0.01s (-0.34d, 0.53p, 0.01std) 0.76x noisy🤷‍♀️, 90.35ms (1.17d, 0.07p, 57.88std) 1.01x invariant, -0.11s (-1.20d, 0.05p, 0.08std) 0.98x invariant, 0.23ms (0.36d, 0.52p, 0.46std) 0.99x invariant, 0.43ms (0.66d, 0.24p, 0.65std)

@SimonDanisch SimonDanisch merged commit a679147 into master Mar 19, 2024
18 checks passed
@SimonDanisch SimonDanisch deleted the RomeoV/master branch March 19, 2024 10:44
@RomeoV
Copy link
Contributor

RomeoV commented Mar 19, 2024

Thanks for merging @SimonDanisch ! I just thought about it once more, perhaps it should be

bar_label_formatter(label::AbstractString) = label

instead of the just merged

bar_label_formatter(label::String) = label
bar_label_formatter(label::LaTeXString) = label

? Sorry for only bringing this up now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants