New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Cairo scatter marker conversion to be overridden #3811
Conversation
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running: using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
|
Tested this with MakieTeX and the API works great. This also removes FFTW as a direct dependency of CairoMakie. |
Was this already reviewed? |
By Simon on Slack, yes |
* Upgrade to DelaunayTriangulation v1.0 (#3787) * Upgrade to DelaunayTriangulation v1.0 * Updates for DelaunayTriangulation v1.0 * changelog * Allow Cairo scatter marker conversion to be overridden (#3811) * Define cairo_scatter_marker api * Bump CairoMakie version * Implement cairo_scatter_marker API for scatter and meshscatter * Add to changelog * MeshScatter conversion is different, don't implement * fix ticks for categorical colorbar (#3762) * Update tricontourf.md in 0.20.10 branch (#3828) Update tricontourf.md * fix docs --------- Co-authored-by: Daniel VandenHeuvel <95613936+DanielVandH@users.noreply.github.com> Co-authored-by: Simon <sdanisch@protonmail.com>
Description
This PR allows external packages like MakieTeX to override
Makie.to_spritemarker
for Cairo and vector formats, while still exploitingMakie.to_spritemarker
to convert to images.The PR also bumps the CairoMakie version to prepare for a release.
Type of change
Delete options that do not apply:
Checklist