Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Greenland ice loss example #39

Merged
merged 11 commits into from
Apr 29, 2023
Merged

Add Greenland ice loss example #39

merged 11 commits into from
Apr 29, 2023

Conversation

alex-s-gardner
Copy link
Contributor

I've added an interactive-animated plotting of Greenland ice loss

docs/src/assets/data/iceloss_subset.arrow Outdated Show resolved Hide resolved
docs/src/assets/iceloss.mp4 Outdated Show resolved Hide resolved
@alex-s-gardner
Copy link
Contributor Author

Not clear to me why the documenter failed... is it because the example downloads a file?

@rafaqz
Copy link
Collaborator

rafaqz commented Apr 27, 2023

I think there is a separate problem with the docs

@alex-s-gardner
Copy link
Contributor Author

The remaining error in the Documenter build looks related to the use of LightOSM in the osmmakie example

@lazarusA
Copy link
Collaborator

LightOSM in the osmmakie

indeed, that example is too brittle.

@SimonDanisch
Copy link
Member

Ah yeah, almost forget about it, but I've been fighting with that... I think there's an issue in LightOSM, which I haven't reported yet

@SimonDanisch
Copy link
Member

DeloitteOptimalReality/LightOSM.jl#94

@alex-s-gardner
Copy link
Contributor Author

Should we go ahead an merge this PR while the LightOSM issue is getting ironed out?

@rafaqz rafaqz merged commit 53949d1 into MakieOrg:master Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants