Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.16.9plus #10

Closed
wants to merge 6 commits into from
Closed

0.16.9plus #10

wants to merge 6 commits into from

Conversation

mvvvv
Copy link
Contributor

@mvvvv mvvvv commented Sep 13, 2023

sphere_ptr cannot be null as tex_gen_cubemap test that.

@technobaboo
Copy link
Collaborator

looks good to me but i can't test it, does it work?

@mvvvv
Copy link
Contributor Author

mvvvv commented Sep 13, 2023

It doesn't work at all without the modification. I have a video proof that the pull request works
https://youtu.be/besJBDEecFI?t=110

@mvvvv mvvvv closed this Sep 21, 2023
@mvvvv mvvvv deleted the 0.16.9plus branch September 21, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants