Fix multiple duplication bugs and NPE #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworked the slotClick and transferStackInSlot logic. I'm not 100% sure what was causing the errors, but these refactors have fixed - Bug where shift clicking items out used 2 items but only gave 1 - Bug where using the number keys to remove items duped huge amounts
Tested with EnderIO. Previously when using EnderIO item conduits, it would attempt to take multiple items (and add that many to the input inventory), but only decrement storage by 1. Now correctly handle the case where item cables try to extract more than one item at a time.
Sometimes this method gets called with slotPos -999, not sure why, but just put a check to ignore any events that have a slotPos outside the expected bounds and this fixes it.
|
Hey @Malorolam, any chance of you taking a look at this PR? Happy to help with general maintainance too if you'd like, for example replying to/closing issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #185 where it removes 2 but only gives one lootbag when shift clicking
Fix #188 fix #178 where using the number keys gives a stack when it should only give 1.
Pretty sure it fixes #191, although their description seems the opposite of the bug I'm seeing.
Also fixed two bugs I found myself. One where using pipes (tested with EnderIO), it will extract a larger number of bags than it removes, thus duping bags.
Second, a null pointer when interacting with the bags GUI sometimes.