Skip to content

Commit

Permalink
Merge pull request dequelabs#2043 from dequelabs/release-3.5.1
Browse files Browse the repository at this point in the history
Release 3.5.1
  • Loading branch information
WilcoFiers committed Feb 13, 2020
2 parents a8702a4 + 609ecf9 commit 2771425
Show file tree
Hide file tree
Showing 11 changed files with 9,779 additions and 25 deletions.
6 changes: 4 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
- checkout
- <<: *set_npm_auth
- <<: *restore_dependency_cache_unix
- run: npm install
- run: npm ci
- save_cache:
key: v8-cache-unix-{{ checksum "package.json" }}
paths:
Expand All @@ -51,7 +51,7 @@ jobs:
- checkout
- <<: *set_npm_auth
- <<: *restore_dependency_cache_win
- run: npm install
- run: npm ci
- save_cache:
key: v8-cache-win-{{ checksum "package.json" }}
paths:
Expand Down Expand Up @@ -158,6 +158,7 @@ jobs:
- <<: *set_npm_auth
- <<: *restore_dependency_cache_unix
- run: npm run build
- run: npm run sri-validate
- run: npm publish

# Create a GitHub release.
Expand Down Expand Up @@ -211,6 +212,7 @@ workflows:
type: approval
requires:
- test_unix
- test_win
- test_examples
- test_locales
- build_api_docs
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# defaults
node_modules
npm-shrinkwrap.json
package-lock.json
doc/examples/*/package-lock.json
.DS_Store
.vscode

Expand Down
1 change: 0 additions & 1 deletion .npmrc
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
package-lock=false
registry=https://registry.npmjs.org
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

### [3.5.1](https://github.com/dequelabs/axe-core/compare/v3.5.0...v3.5.1) (2020-02-12)

### Bug Fixes

- **color-contrast:** parse font-weight value as number ([#2031](https://github.com/dequelabs/axe-core/issues/2031)) ([#2040](https://github.com/dequelabs/axe-core/issues/2040)) ([0bb2166](https://github.com/dequelabs/axe-core/commit/0bb21669f75b3adc0e3345c85680d437c57f94d8))
- **color-contrast:** properly pass options to check ([#2033](https://github.com/dequelabs/axe-core/issues/2033)) ([26b99c0](https://github.com/dequelabs/axe-core/commit/26b99c0a511bd6fffaaca7535d732f26b39ef46e))
- **commons:** avoid unicode regex encoding in axe.min.js ([#2024](https://github.com/dequelabs/axe-core/issues/2024)) ([ae90dc4](https://github.com/dequelabs/axe-core/commit/ae90dc47521f6047f71befcb3551686cf857208d))
- **sri-history:** correct SRI for various versions ([#2041](https://github.com/dequelabs/axe-core/issues/2041)) ([940c017](https://github.com/dequelabs/axe-core/commit/940c01708cede33e796972ce810a815ddf492ba4))

## [3.5.0](https://github.com/dequelabs/axe-core/compare/v3.4.0...v3.5.0) (2020-02-04)

### Features
Expand Down
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "axe-core",
"version": "3.5.0",
"version": "3.5.1",
"contributors": [
{
"name": "David Sturley",
Expand Down
5 changes: 2 additions & 3 deletions lib/checks/color/color-contrast.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,8 @@ const fgColor = color.getForegroundColor(node, noScroll, bgColor);

const nodeStyle = window.getComputedStyle(node);
const fontSize = parseFloat(nodeStyle.getPropertyValue('font-size'));
const fontWeight = nodeStyle.getPropertyValue('font-weight');
const bold =
['bold', 'bolder', '600', '700', '800', '900'].indexOf(fontWeight) !== -1;
const fontWeight = parseFloat(nodeStyle.getPropertyValue('font-weight'));
const bold = !isNaN(fontWeight) && fontWeight >= 700;

const cr = color.hasValidContrastRatio(bgColor, fgColor, fontSize, bold);

Expand Down
2 changes: 1 addition & 1 deletion locales/fr.json
Original file line number Diff line number Diff line change
Expand Up @@ -838,5 +838,5 @@
"failureMessage": "Corriger tous les éléments suivants : {{~it:value}}\n {{=value.split('\\n').join('\\n ')}}{{~}}"
}
},
"incompleteFallbackMessage": "axee n'a pu en déterminr la raison. Il est temps de sortir l'inspecteur d'éléments!"
"incompleteFallbackMessage": "axe n'a pu en déterminer la raison. Il est temps de sortir l'inspecteur d'éléments!"
}
Loading

0 comments on commit 2771425

Please sign in to comment.