Create gem

[jvlcek]

As discussed with @Fryguy this pull request represents the work I was able to do according to the instructions on building a gem.

It also includes a fix to provide default options if the user does not provide a YAML file,
which could happen if they logged in manually before using this gem.

EDIT @Fryguy: Removed link because it's not publicly accesbile anyway.

[coveralls]

Changes Unknown when pulling fa4e295 on jvlcek:create_gem into * on ManageIQ:master*.

[Fryguy]

The spec is failing on JRuby because of how the tempfile creator is creating the file. Since the code is running on travis, we probably don't have access to write to a directory. I have 2 suggestions.

1. Remove JRuby support from the travis.yml. It also seems there's a problem with Rubyinius 1.8, so remove that as well. Since we are using LinuxAdmin for shelling out, I don't think those two will work anyway.
2. Change the interface to ruby_bugzilla to not require a file. I think the API for ruby_bugzilla should have parameters to login that the user can specify. In addition, there could be class accessors for setting it once in code. We may want to remove the class accessors in favor of instance methods, but maybe that can come later.

[coveralls]

Changes Unknown when pulling 0225ece on jvlcek:create_gem into * on ManageIQ:master*.

[jvlcek]

@Fryguy and @jrafanie

I'd first like to implement your suggestion #1 "Removed JRuby and Rubyinius 1.8 support from the travis.yml."

I also like your suggestion #2 "Changing the interface to ruby_bugzilla to not require a file." but I would rather tackle that as a separate issue and for now focus on adding "modify" support.

[jrafanie]

@jvlcek It says "Removed JRuby and Rubinius 1.9 support from the travis.yml" in both the commit message, the yaml file and this pull request's description but @Fryguy mentioned that it was JRuby and Rubinius 1.8 that was a problem. Can you confirm what version is the issue and make any corrections to the travis.yml and commit messages to make to very clear which ruby implementations are being disabled for now.

Additionally, please open a ticket to add support for those implementations if it's easy to do.

Finally, I think we need to bump the minor or patch version number to abide by semantic versioning since you're adding a dependency for coveralls, http://semver.org/

[coveralls]

Changes Unknown when pulling 29c576f on jvlcek:create_gem into * on ManageIQ:master*.

[jvlcek]

@jrafanie, I've corrected the commit message and this pull request's description to correctly identify Rubinius 1.8 that.

I've updated the minor version for the coveralls dependency.

I have the functionality ready for Jason's API change suggestinos and will post it in a pull request once this is merged.

Thank you!
JoeV

[coveralls]

Changes Unknown when pulling e5c0e77 on jvlcek:create_gem into * on ManageIQ:master*.

[coveralls]

Changes Unknown when pulling 0bb5f8e on jvlcek:create_gem into * on ManageIQ:master*.

[Fryguy]

Don't use class variables. As much as you think they make sense, in this case, they don't, unfortauntely. Prefer class-instance variables. So, you don't need these two lines at all, and in the next 4 methods, just use single-@ instead of double-@

[jvlcek]

D'oh! Of course... Thanks for catching that.

[jvlcek]

@Fryguy Thank you again for the feedback. I believe I've address the issues you've raised. I slightly changed the way you suggested to code the credentials method by allowing for username and password to be input parameters to that method. I think it might be valuable to the user of the API.

[coveralls]

Changes Unknown when pulling 6a9fac4 on jvlcek:create_gem into * on ManageIQ:master*.

[jvlcek]

@Fryguy and @jrafanie Now that we are through the blocker bugs can you please finalize this and merge if my latest updates satisfactorily address all the issue raised.