Refactor the Podman runner to be a Docker subclass #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
force-pushed
the
refactor_docker_podman_runners
branch
from
8186963
to
1d6b623
Compare
agrare
force-pushed
the
refactor_docker_podman_runners
branch
from
1d6b623
to
98e72d9
Compare
|
Checked commit agrare@98e72d9 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
|
wow. |
100% just need to extract the params to a method then we can drop that one as well |
agrare
added a commit
that referenced
this pull request
Nov 9, 2023
Added - Prefix pod names with 'floe-' (#132) - Validate that the workflow payload is correct (#136) Fixed - Fix issue where certain docker image names cannot be pod names (#134) - Fix uninitialized constant RSpec::Support::Differ in tests (#137) - Handle ImagePullErr/ImagePullBackOff as errors (#135) Changed - Add task spec helper (#123) - Rename State#run_wait to just #wait (#139) - Refactor the Podman runner to be a Docker subclass (#140)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two are so close that it seems like only a few overrides will allow us to remove a good amount of duplication