Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set workflow output on completion #57

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

agrare
Copy link
Member

@agrare agrare commented Jul 11, 2023

When a workflow completes, set the last state's output as the workflow
output

@agrare agrare requested a review from Fryguy as a code owner July 11, 2023 16:59
@agrare agrare added the enhancement New feature or request label Jul 11, 2023
@agrare agrare force-pushed the add_workflow_output_on_completion branch 2 times, most recently from 3af5a62 to 457471e Compare July 11, 2023 17:00
@agrare
Copy link
Member Author

agrare commented Jul 11, 2023

@kbrock this was one of the things we discussed last week in passing, lmk what you think

Copy link
Member

@kbrock kbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agrare LGTM. I had expected output to end up in the state (rather than an instance variable)
But this looks good

When a workflow completes, set the last state's output as the workflow
output
@agrare agrare force-pushed the add_workflow_output_on_completion branch from 457471e to 547e25b Compare July 12, 2023 11:48
@miq-bot
Copy link
Member

miq-bot commented Jul 12, 2023

Some comments on commit agrare@547e25b

exe/floe

  • ⚠️ - 39 - Detected puts. Remove all debugging statements.

@miq-bot
Copy link
Member

miq-bot commented Jul 12, 2023

Checked commit agrare@547e25b with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@kbrock kbrock merged commit f639c51 into ManageIQ:master Jul 12, 2023
5 checks passed
@agrare agrare deleted the add_workflow_output_on_completion branch July 12, 2023 13:48
agrare added a commit that referenced this pull request Jul 12, 2023
Fixed
- Fix State EnteredTime and FinishedTime (#59)

Added
- Add workflow output (#57)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants