Simplify next state handling only return state name #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The State classes don't need to return the next state object, just the name. The Workflow class can lookup the state object by the name since it owns the hash of state objects.
agrare
force-pushed
the
simplify_next_state_handling
branch
from
66b0c21
to
f5937e1
Compare
1 task
|
Checked commit agrare@f5937e1 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The State classes don't need to return the next state object, just the name. The Workflow class can lookup the state object by the name since it owns the hash of state objects.
Previously the
State#run!method had to look the state object up from the workflow object, this cleans that access pattern up.