Fix errors with out of date comma cops

[NickLaMuro]

This prevents rubocop from running properly.

Error in question:

Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop-https---raw-githubusercontent-com-ManageIQ-guides-master--rubocop-base-yml, please update it)

Updated to use both cops to retain the same functionality.

Links

• Changed in rubocop here: [Fix #3394] Separate Array & Hash Literal Comma configuration rubocop/rubocop#5307
• Original rubocop rational: Allow TrailingCommaInLiteral to enforce Arrays but not Hashes rubocop/rubocop#3394

[NickLaMuro]

@Fryguy and/or @bdunne I believe you are the resident "rubocop Czars" around here. I leave this to you.

[bdunne]

These are not compatible with our current version of rubocop.
https://github.com/ManageIQ/miq_bot/blob/master/Gemfile#L52
https://github.com/ManageIQ/manageiq/blob/master/Gemfile#L218

My bundle shows rubocop v0.52.1 and if I include this change, I see:

Warning: unrecognized cop Style/TrailingCommaInArrayLiteral found in .rubocop_local.yml
Warning: unrecognized cop Style/TrailingCommaInHashLiteral found in .rubocop_local.yml

Are you also suggesting updating the version of rubocop?

[NickLaMuro]

@bdunne you know what, I goofed, and I think this was on me.

tl; dr No, wasn't suggesting we upgrade. We can keep this around though if we decide to upgrade, though (since not having this change when you upgrade will prevent rubocop from running properly).

So, what I did wrong...

• Missed that the change in the the CHANGELOG.md (second bullet) was in the v0.53.0 release, not v0.52.1.
• Did a fresh bundle in my local linux_admin, which doesn't have a hard lock on the rubocop version, and started me at v.0.53.0.
• Ran into the error from above, so tried downgrading to a known working version (v0.52.1)
• Was running with just rubocop in both cases instead of bundle exec rubocop, which used the v0.53.0 release each time, and was showing the error.

So basically, I was thinking this was an issue on our bot because I recently helped upgrade that:

ManageIQ/miq_bot#410

---

Anyway, as mentioned, it is up to you I guess on what you want to do with this. Sorry for the PR based on user error 😖

[martinpovolny]

@bdunne , @NickLaMuro : shall I close this one?