This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Fix datastore SmartState analysis tests #10295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarovo
changed the title
mshriver
reviewed
Sep 1, 2020
mshriver
reviewed
Sep 1, 2020
mshriver
reviewed
Sep 1, 2020
mshriver
reviewed
Sep 1, 2020
mshriver
reviewed
Sep 1, 2020
mshriver
suggested changes
Sep 1, 2020
mshriver
changed the title
jarovo
changed the title
jarovo
changed the title
jarovo
changed the title
This fixes the SSA on datastores by navigating to the datastores from
provider and then starting the test.
Also
Resolve circular imports
Fixes:
File "/cfme/cfme_tests/cfme/utils/providers.py", line 16, in <module>
from cfme.common.provider import all_types
ImportError: Error importing plugin "cfme.markers.env": cannot import name 'all_types' from 'cfme.common.provider' (/cfme/cfme_tests/cfme/common/provider.py)
jarovo
changed the title
|
I detected some fixture changes in commit 4c661d8 The local fixture
The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
mshriver
approved these changes
Sep 3, 2020
mshriver
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
Workaround SSA not possible on RHV datastores depending on the navigation path taken when navigating to it manageiq#20367 by starting the SSA using different navigation path, which fixes cfme/tests/infrastructure/test_datastore_analysis.py tests.
Improvement: moved some items to solve circular dependencies between modules.
PRT Run
There was some openstack related test that failed. Doesn't seem related to my PR.