Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSA not possible on RHV datastores depending on the navigation path taken when navigating to it #20367

Open
jarovo opened this issue Jul 17, 2020 · 11 comments

Comments

@jarovo
Copy link

jarovo commented Jul 17, 2020

Description of problem:

Starting the SmartState Analysis is not handled in consistent way across providers.

From All datastores page

Compute -> Infrastructure -> Datastores; [Select one RHV DS from the list], [Click on Configure -> Start SSA]

The button for starting the analysis of datastore on RHV providers is enabled, but the start is not sucesfull with message: "SmartState Analysis action does not apply to selected items". On vmware provider, the SSA starts fine.

From Provider datastores page

Compute -> Infrastructure -> Providers; [Select RHV provider], [Select Datastores], [Check one DS from the list], [Click on Configure -> Start SSA]

The SSA starts on datastore of both -- vmware as well as RHV. Message ... scan successfully initiated when trying from the datastore Details page" is displayed.

From Datastore Details page:

Compute -> Infrastructure -> Providers; [Select RHV provider], [Select Datastores from the table].

It seems no matter which navigation path is taken, The Configure button is disabled on RHV. It is enabled on vmware and works fine.

Version-Release number of selected component (if applicable):

5.11.6.0.20200526234234_3fcafeb
5.11.7.0.20200714215453_0da8a4

How reproducible:

1/1 For each CFME version noted.
It is important to note that when vmware provider is deleted, some items are archived, which can manifest as duplicated items (datastores for example) and that may cause a confusion.

Steps to Reproduce:

  1. Add a RHV and vmware provider
  2. Go to datastore trough provider and select it or select some DS from the All datastores page or display Details page of the datastore
  3. Click on button for starting SSA

Actual results:

When not going trough the provider, SSA is not allowed:
SmartState Analysis action does not apply to selected items
is displayed

Expected results:

Hard to tell what should be expected. The compatibility matrix is not really populated for RHV in the documentation. The behaviour is not consistent even for single CFME version and single provider.

https://bugzilla.redhat.com/show_bug.cgi?id=1858107

@jarovo jarovo changed the title SSA not possible on any RHV datastore depending on navigation to it. SSA not possible on datastores depending on a provider and the path taken when navigating to it Jul 20, 2020
@jarovo jarovo changed the title SSA not possible on datastores depending on a provider and the path taken when navigating to it SSA not possible on datastores depending on a CFME version, provider and the path taken when navigating to it Jul 20, 2020
@jarovo jarovo changed the title SSA not possible on datastores depending on a CFME version, provider and the path taken when navigating to it SSA not possible on RHV datastores depending on the navigation path taken when navigating to it Jul 20, 2020
@jerryk55
Copy link
Member

@JaryN do you have an environment available that I can use to try to reproduce this? Thanks much.

@jarovo
Copy link
Author

jarovo commented Jul 20, 2020 via email

@jerryk55
Copy link
Member

@JaryN, on the above provided appliance, I would say that datastore SSA is behaving as expected with regard to the "path taken when navigating to it". On the datastores for which SSA is currently "valid", you can start it successfully in both the list view and detail view. On the datastores for which SSA is not valid, in the list view you can make the request, but you will get a popup saying that SSA does not apply for the selected datastore. And if you drill down into the detailed view for that datastore, the SSA operation under Configuration is grayed-out since it does not apply. I don't see any inconsistency between the detail view and the list view.

Now, I can't tell you offhand whether these datastores should actually be scannable - but that is not the purpose of this issue as I read it.

@jarovo
Copy link
Author

jarovo commented Jul 21, 2020

@JaryN, on the above provided appliance, I would say that datastore SSA is behaving as expected with regard to the "path taken when navigating to it". On the datastores for which SSA is currently "valid", you can start it successfully in both the list view and detail view. On the datastores for which SSA is not valid, in the list view you can make the request, but you will get a popup saying that SSA does not apply for the selected datastore. And if you drill down into the detailed view for that datastore, the SSA operation under Configuration is grayed-out since it does not apply. I don't see any inconsistency between the detail view and the list view.

Now, I can't tell you offhand whether these datastores should actually be scannable - but that is not the purpose of this issue as I read it.

My main issue is the SSA of RHV provider does start when navigating trough the provider, but when selecting the same datastore from All datastores page, it is not possible to start the SSA. So I conclude SSA on RHV is possible. The code enabling the buttons is inconsistent and chooses to disable the SSA starting (Configure) button in some navigation path while chooses to enable starting SSA in other. So this almost certainly is a UI bug, not a SSA bug.

@jerryk55
Copy link
Member

If you get a popup that says "SSA does not apply for the selected datastore", then SSA is not starting. In the list view, since you can select more than one element in the list, I would not think there would be a way to gray out the SSA button, while it is possible in the detail view. This is the precisely the same behavior that is available for VM SSA - for instance on VMware if the VixDIskLib library is not installed - in the list view you can still click on the SSA selection, but not in the detail view.. It has nothing to do with datastores, and has everything to do with the way the web controller operates.

@jarovo
Copy link
Author

jarovo commented Jul 21, 2020

If you get a popup that says "SSA does not apply for the selected datastore", then SSA is not starting. In the list view, since you can select more than one element in the list, I would not think there would be a way to gray out the SSA button, while it is possible in the detail view. This is the precisely the same behavior that is available for VM SSA - for instance on VMware if the VixDIskLib library is not installed - in the list view you can still click on the SSA selection, but not in the detail view.. It has nothing to do with datastores, and has everything to do with the way the web controller operates.

But I am able to get "scan successfully initiated" displayed. The problem is that only when navigating trough the provider and using checkbox. When on Details page or on All datastores page using checkbox, it is not possible to start the SSA on same datastore.

I am posting a video to the BZ as I don't want to share the IP displayed on it.

@jerryk55
Copy link
Member

Ah. ok. So the real question is - why does SSA appear to work in the provider list when you drill down through the RHEV provider, but not when you go directly to the datastores list. At no point does it work in the detail. Additionally - is it really working? There seems to be alot of data missing for this to be considered successful. Finally - can you provide an environment where you can successfully run SSA on a RHEV datastore? Since I've never even looked at Datastore SSA I'm not sure what a successful run is supposed to look like - other than the VMware datastores visible on this appliance.

@jarovo
Copy link
Author

jarovo commented Jul 21, 2020 via email

@jerryk55
Copy link
Member

Oh I guess I was under the impression that the CFME version was relevant, but now I see you modified that part of the title of this issue. Never mind about another system.

@gtanzillo
Copy link
Member

/cc @h-kataria

@mzazrivec
Copy link
Contributor

The problem described here was fixed in upstream a while ago in ManageIQ/manageiq-ui-classic#6224

We have a PR to backport it to ivanchuk: ManageIQ/manageiq-ui-classic#7241

The core of the problem was that we'd run SSA for a completely different (i.e. incorrect) type of object, not for the actual datastore. So yes, this was purely an UI issue and this report here can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants