This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Added appliance fixture #4316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| pytestmark = [pytest.mark.usefixtures("start_evmserverd_after_module")] | ||
|
|
||
|
|
||
| @pytest.mark.tier(1) | ||
| def test_evmserverd_stop(ssh_client): | ||
| def test_evmserverd_stop(appliance): |
There was a problem hiding this comment.
why replace ssh_client there?
There was a problem hiding this comment.
Because it should be gotten from appliance not from some mad global ssh_client
mshriver
reviewed
Mar 8, 2017
| @@ -30,26 +30,28 @@ def test_evmserverd_stop(ssh_client): | |||
| * For 5.5+: Really call ``service evmserverd status`` and check that the mentions of | |||
| stopping the service are present. | |||
| """ | |||
| server_names = {server["Server Name"] for server in ssh_client.status["servers"]} | |||
| assert ssh_client.run_command("service evmserverd stop").rc == 0 | |||
| server_names = {server["Server Name"] for server in appliance.ssh_client.status["servers"]} | |||
There was a problem hiding this comment.
This is raising a KeyError upstream for 'Server Name' but that's outside your intended scope here.
mshriver
reviewed
Mar 8, 2017
| @@ -30,9 +27,8 @@ def test_login(method): | |||
|
|
|||
| @pytest.mark.tier(2) | |||
| @pytest.mark.sauce | |||
| def test_bad_password(request): | |||
| def test_bad_password(request, appliance): | |||
There was a problem hiding this comment.
failing in 5.6 and 5.7 PRT but outside the scope of this change.
mshriver
approved these changes
Mar 8, 2017
mshriver
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding appliance fixture