This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Migration Plans Refactoring #8404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-dupuy
reviewed
Jan 28, 2019
digitronik
suggested changes
Jan 29, 2019
digitronik
changed the title
sshveta
changed the title
digitronik
suggested changes
Jan 30, 2019
digitronik
changed the title
sshveta
changed the title
digitronik
approved these changes
Jan 30, 2019
dajoRH
changed the title
sshveta
changed the title
dajoRH
changed the title
sshveta
force-pushed
the
migration_plans
branch
from
57081b7
to
d408a77
Compare
sshveta
changed the title
sshveta
changed the title
dajoRH
changed the title
mshriver
reviewed
Apr 2, 2019
mshriver
reviewed
Apr 2, 2019
mshriver
reviewed
Apr 2, 2019
mshriver
reviewed
Apr 2, 2019
mshriver
reviewed
Apr 2, 2019
mshriver
reviewed
Apr 2, 2019
mshriver
reviewed
Apr 2, 2019
mshriver
reviewed
Apr 2, 2019
mshriver
reviewed
Apr 2, 2019
mshriver
reviewed
Apr 2, 2019
mshriver
reviewed
Apr 2, 2019
mshriver
reviewed
Apr 2, 2019
mshriver
suggested changes
Apr 2, 2019
jawatts
changed the title
sshveta
commented
Apr 3, 2019
| """Overriding fill method of TextInput to send | ||
| enter after filling """ | ||
|
|
||
| def fill(self, value): |
There was a problem hiding this comment.
After_fill is not working , it is not called , hence overriding Fill.
def after_fill(self):
self.browser.send_keys(Keys.ENTER, self)
|
@sshveta, looks good at first sight. all tests have been skipped in PRT. why ? |
izapolsk
approved these changes
Apr 4, 2019
|
Test passed on PRT |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration Plan code refactoring .
juwatts:
{{ pytest: cfme/tests/v2v/test_migration_plan.py --use-provider rhv42 --use-provider vsphere67-nested --provider-limit 2 -vvvv --long-running}}