Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with ruby 3.2 and rails 7.1 #122

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

agrare
Copy link
Member

@agrare agrare commented Jan 26, 2024

No description provided.

@agrare agrare requested a review from Fryguy as a code owner January 26, 2024 20:34
@miq-bot miq-bot added the wip label Jan 26, 2024
@miq-bot
Copy link
Member

miq-bot commented Apr 29, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot miq-bot added the stale label Apr 29, 2024
@agrare agrare closed this Apr 29, 2024
@agrare agrare reopened this Apr 29, 2024
@agrare agrare force-pushed the test_ruby_3_2_rails_7_1 branch 2 times, most recently from da7a265 to dad652c Compare April 29, 2024 14:17
@agrare
Copy link
Member Author

agrare commented Apr 29, 2024

ruby 3.2 was failing because of an old version of rake (~> 10.0) being required

@agrare agrare changed the title [WIP] Test with ruby 3.2 and rails 7.1 Test with ruby 3.2 and rails 7.1 Apr 29, 2024
@kbrock
Copy link
Member

kbrock commented Apr 29, 2024

@agrare Do you want to update the code climate code, as well?

Maybe ruby version 3.0?

if: ${{
  github.ref == 'refs/heads/master' &&
  matrix.ruby-version == '2.7' &&
  matrix.rails-version == '6.1'
}}

@agrare
Copy link
Member Author

agrare commented Apr 29, 2024

Do you want to update the code climate code, as well?

👍 good call, updated

@miq-bot
Copy link
Member

miq-bot commented Apr 29, 2024

Checked commit agrare@565a66d with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@kbrock kbrock self-assigned this Apr 29, 2024
@kbrock kbrock merged commit 150dbe1 into ManageIQ:master Apr 29, 2024
15 checks passed
@agrare agrare deleted the test_ruby_3_2_rails_7_1 branch April 29, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants