-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miq persisters to helpers dir #27
Merged
agrare
merged 3 commits into
ManageIQ:master
from
slemrmartin:miq-persisters-to-helpers-dir
Oct 1, 2018
Merged
Miq persisters to helpers dir #27
agrare
merged 3 commits into
ManageIQ:master
from
slemrmartin:miq-persisters-to-helpers-dir
Oct 1, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
And rename/namespace them
slemrmartin
force-pushed
the
miq-persisters-to-helpers-dir
branch
from
October 1, 2018 09:11
7f3683c
to
45cf0de
Compare
Used InventoryRefresh::Persister(Builder) instead
slemrmartin
force-pushed
the
miq-persisters-to-helpers-dir
branch
from
October 1, 2018 09:14
45cf0de
to
c5ee687
Compare
Closed
rubocop and codeclimate fixes in subsequent PR |
Checked commits slemrmartin/inventory_refresh@c897ac4~...c5ee687 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 spec/helpers/test_builder/container_manager.rb
spec/helpers/test_persister.rb
spec/helpers/test_persister/containers.rb
|
agrare
changed the title
[WIP] Miq persisters to helpers dir
Miq persisters to helpers dir
Oct 1, 2018
agrare
approved these changes
Oct 1, 2018
agrare
added a commit
that referenced
this pull request
Oct 1, 2018
[WIP] Miq persisters to helpers dir
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #25
depends on: #26
Moving test persisters based on ManageIQ to helpers under InventoryRefresh persister.
Removing ManageIQ Persister/Builders