Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miq persisters to helpers dir #27

Merged
merged 3 commits into from
Oct 1, 2018

Conversation

slemrmartin
Copy link
Contributor

@slemrmartin slemrmartin commented Sep 27, 2018

Issue #25
depends on: #26

Moving test persisters based on ManageIQ to helpers under InventoryRefresh persister.
Removing ManageIQ Persister/Builders

Used InventoryRefresh::Persister(Builder) instead
@slemrmartin slemrmartin mentioned this pull request Oct 1, 2018
@slemrmartin
Copy link
Contributor Author

rubocop and codeclimate fixes in subsequent PR

@agrare agrare self-assigned this Oct 1, 2018
@miq-bot
Copy link
Member

miq-bot commented Oct 1, 2018

Checked commits slemrmartin/inventory_refresh@c897ac4~...c5ee687 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
18 files checked, 13 offenses detected

spec/helpers/test_builder/container_manager.rb

spec/helpers/test_persister.rb

spec/helpers/test_persister/containers.rb

@agrare agrare changed the title [WIP] Miq persisters to helpers dir Miq persisters to helpers dir Oct 1, 2018
@agrare agrare removed the wip label Oct 1, 2018
@agrare agrare merged commit c5ee687 into ManageIQ:master Oct 1, 2018
agrare added a commit that referenced this pull request Oct 1, 2018
@slemrmartin slemrmartin deleted the miq-persisters-to-helpers-dir branch October 1, 2018 14:26
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants