[security] Config.read: Use YAML.safe_load to avoid arbitrary Ruby class instantiation #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass instantiation Previously used YAML.load designed for deserialization from trusted sources only, allowing `!ruby/object:AnyClass ...` and other risky constructs. The risk depends on ruby classes available in the application; sometimes a class may have side effects - up to arbitrary code execution - when instantiated and/or built up with `x[key] = value` during YAML parsing. Despite this fix, using untrusted config is still a questionable idea!
grosser
reviewed
May 31, 2018
lib/kubeclient/version.rb
Outdated
| @@ -1,4 +1,4 @@ | |||
| # Kubernetes REST-API Client | |||
| module Kubeclient | |||
| VERSION = '3.1.0'.freeze | |||
| VERSION = '3.1.1'.freeze | |||
There was a problem hiding this comment.
bump should happen on master
grosser
reviewed
May 31, 2018
CHANGELOG.md
Outdated
| @@ -4,6 +4,15 @@ Notable changes to this project will be documented in this file. | |||
| The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). | |||
| Kubeclient release versioning follows [SemVer](https://semver.org/). | |||
|
|
|||
| ## 3.1.1 - 2018-05-31 | |||
There was a problem hiding this comment.
OK, took out bump, changed this to "Unreleased"
|
👍 ... I guess version bumping is fine if this get's merged and released as it is ... but in general prefer not bumping in a PR |
cben
added a commit
to cben/kubernetes-deploy
that referenced
this pull request
May 31, 2018
… class instantiation Same as ManageIQ/kubeclient#334.
dturn
pushed a commit
to Shopify/krane
that referenced
this pull request
Jun 1, 2018
… class instantiation (#295) Same as ManageIQ/kubeclient#334.
Merged
This was referenced Jun 7, 2018
Merged
cben
added a commit
to cben/kubeclient
that referenced
this pull request
Dec 2, 2018
Promised in README since 040d6ea (ManageIQ#334). Didn't work - absolute path lookups were allowed! Test passed because some of the paths were still relative.
cben
added a commit
to cben/kubeclient
that referenced
this pull request
Dec 2, 2018
Promised in README since 040d6ea (ManageIQ#334). Didn't work - absolute path lookups were allowed! Test passed because some of the paths were still relative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously used YAML.load designed for deserialization from trusted sources only, allowing
!ruby/object:AnyClass ...and other risky constructs.The risk depends on ruby classes available in the application; sometimes a class may have side effects - up to arbitrary code execution - when instantiated and/or built up with
x[key] = valueduring YAML parsing.[See https://www.sitepoint.com/anatomy-of-an-exploit-an-in-depth-look-at-the-rails-yaml-vulnerability/ for one detailed example how
YAML.loadmade Rails vulnerable, and ruby/psych#119 for more links]Documented
Config.readandConfig.newbetter.Documented when config may read other files from file system.
☹️ , fixed in Really enforce Config.new(data, nil) prevents external file lookups #372.
Added tests forUPDATE: no it didn't prevent thisConfig.new(data, nil)preventing this (this happens via TypeError, might improve to nicer exception but out of scope here).Added warning that despite this fix, using untrusted config remains a questionable idea!
@moolitayer @grosser @pkliczewski @masayag please review.
@moolitayer, I want to release this quickly, possibly by myself.
(Hence CHANGELOG and version bump all in one PR.)