Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Unicode characters in httpd auth headers #1031

Merged
merged 1 commit into from Apr 22, 2021
Merged

Handle Unicode characters in httpd auth headers #1031

merged 1 commit into from Apr 22, 2021

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Apr 21, 2021

@Fryguy Fryguy requested a review from bdunne as a code owner April 21, 2021 21:47
@Fryguy Fryguy mentioned this pull request Apr 21, 2021
Merged
3 tasks
@miq-bot
Copy link
Member

miq-bot commented Apr 21, 2021

Checked commit Fryguy@73ee0df with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@jrafanie jrafanie merged commit 050a977 into ManageIQ:master Apr 22, 2021
@Fryguy
Copy link
Member Author

Fryguy commented Apr 22, 2021

Backported to lasker in commit 15fdf4b.

commit 15fdf4bb68c20754fde8790fb709873cc48b3664
Author: Joe Rafaniello <jrafanie@users.noreply.github.com>
Date:   Thu Apr 22 12:11:26 2021 -0400

    Merge pull request #1031 from Fryguy/handle_unicode_chars_in_headers
    
    Handle Unicode characters in httpd auth headers
    
    (cherry picked from commit 050a9774ff097a055b487dd5cb8c7ecf51cd0193)

Fryguy pushed a commit that referenced this pull request Apr 22, 2021
@jrafanie @Fryguy
Merge pull request #1031 from Fryguy/handle_unicode_chars_in_headers
15fdf4b 
Handle Unicode characters in httpd auth headers

(cherry picked from commit 050a977)
@Fryguy
Copy link
Member Author

Fryguy commented Apr 27, 2021

Backported to kasparov in commit 85ecca9.

commit 85ecca9bf5b43b6ac4d8d34d1b4ae42a40a2ca4f
Author: Joe Rafaniello <jrafanie@users.noreply.github.com>
Date:   Thu Apr 22 12:11:26 2021 -0400

    Merge pull request #1031 from Fryguy/handle_unicode_chars_in_headers
    
    Handle Unicode characters in httpd auth headers
    
    (cherry picked from commit 050a9774ff097a055b487dd5cb8c7ecf51cd0193)

Fryguy pushed a commit that referenced this pull request Apr 27, 2021
@jrafanie @Fryguy
Merge pull request #1031 from Fryguy/handle_unicode_chars_in_headers
85ecca9 
Handle Unicode characters in httpd auth headers

(cherry picked from commit 050a977)
@Fryguy Fryguy deleted the handle_unicode_chars_in_headers branch June 8, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrafanie jrafanie jrafanie approved these changes

@bdunne bdunne Awaiting requested review from bdunne bdunne is a code owner

Assignees

@jrafanie jrafanie

Labels
bug kasparov/backported lasker/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Fryguy @miq-bot @jrafanie