Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added endpoints for physical storage families, resources and services #1190

Merged
merged 1 commit into from Dec 21, 2022

Conversation

galoiring
Copy link
Contributor

We added the relevant endpoints and controllers.
They will be needed to access capability values fields added in:
ManageIQ/manageiq-schema#676

Screen Shot 2022-12-04 at 16 35 16

Screen Shot 2022-12-04 at 16 36 05

Screen Shot 2022-12-04 at 16 36 46

W/ @OrGur1987

@galoiring
Copy link
Contributor Author

galoiring commented Dec 7, 2022

@agrare could you have a look at this?

@agrare agrare self-assigned this Dec 7, 2022
@agrare
Copy link
Member

agrare commented Dec 7, 2022

@galoiring can you add spec tests for these new endpoints? The spec/requests/physical_racks_spec.rb looks like a good basic controller to model off of

@OrGur1987
Copy link
Contributor

OrGur1987 commented Dec 8, 2022

@galoiring can you add spec tests for these new endpoints? The spec/requests/physical_racks_spec.rb looks like a good basic controller to model off of

we added the specs but didn't manage to run them locally on our machine (some problem with api_basic_authorize()).
also, we seem to fail in api_config_spec.rb on 'contains only valid MiqProductFeature identifiers'

@agrare
Copy link
Member

agrare commented Dec 8, 2022

Those are valid failures, product features for new api endpoints must be added to https://github.com/ManageIQ/manageiq/blob/master/db/fixtures/miq_product_features.yml

@OrGur1987
Copy link
Contributor

OrGur1987 commented Dec 10, 2022

Those are valid failures, product features for new api endpoints must be added to https://github.com/ManageIQ/manageiq/blob/master/db/fixtures/miq_product_features.yml

ManageIQ/manageiq#22274

do we need to add these endpoints in other places?
for instance under some category in manageiq/db/fixtures/miq_user_roles.yml?

@agrare
Copy link
Member

agrare commented Dec 12, 2022

@miq-bot cross-repo-tests ManageIQ/manageiq#22274

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Dec 12, 2022
@agrare
Copy link
Member

agrare commented Dec 12, 2022

@galoiring please review the failures in https://github.com/ManageIQ/manageiq-cross_repo-tests/actions/runs/3676827582/jobs/6217967590

The authentication ones aren't related but the rest look like they are introduced by this PR. Please run the -api specs locally with your manageiq changes applied and the core repo linked via spec/manageiq -> ../manageiq

@OrGur1987 OrGur1987 force-pushed the add_capabilities_to_jsonb branch 2 times, most recently from d192782 to b5b83f4 Compare December 14, 2022 09:04
@galoiring
Copy link
Contributor Author

@miq-bot cross-repo-tests ManageIQ/manageiq#22274

@miq-bot
Copy link
Member

miq-bot commented Dec 18, 2022

@galoiring Only members of the ManageIQ organization may use this command.

@llivne
Copy link

llivne commented Dec 18, 2022

@miq-bot cross-repo-tests ManageIQ/manageiq#22274

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Dec 18, 2022
@agrare
Copy link
Member

agrare commented Dec 19, 2022

Core PR with product features has been merged

@agrare agrare closed this Dec 19, 2022
@agrare agrare reopened this Dec 19, 2022
@agrare agrare closed this Dec 19, 2022
@agrare agrare reopened this Dec 19, 2022
@agrare
Copy link
Member

agrare commented Dec 19, 2022

@galoiring the spec failure looks legit please address

@miq-bot
Copy link
Member

miq-bot commented Dec 20, 2022

Checked commit Autosde@fb9b172 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
6 files checked, 0 offenses detected
Everything looks fine. 🍪

@galoiring
Copy link
Contributor Author

@agrare fixed.

@agrare agrare merged commit fcf7b53 into ManageIQ:master Dec 21, 2022
@Fryguy Fryguy added this to the Petrosian milestone Sep 14, 2023
@Fryguy Fryguy added this to Petrosian in Roadmap Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Roadmap
  
Petrosian
Development

Successfully merging this pull request may close these issues.

None yet

6 participants