New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added endpoints for physical storage families, resources and services #1190
Conversation
8b125d6
to
f31a6f1
Compare
@agrare could you have a look at this? |
@galoiring can you add spec tests for these new endpoints? The |
f31a6f1
to
6253814
Compare
we added the specs but didn't manage to run them locally on our machine (some problem with |
Those are valid failures, product features for new api endpoints must be added to https://github.com/ManageIQ/manageiq/blob/master/db/fixtures/miq_product_features.yml |
6253814
to
1a3552b
Compare
do we need to add these endpoints in other places? |
1a3552b
to
7e3a7c7
Compare
@miq-bot cross-repo-tests ManageIQ/manageiq#22274 |
From Pull Request: ManageIQ/manageiq-api#1190
@galoiring please review the failures in https://github.com/ManageIQ/manageiq-cross_repo-tests/actions/runs/3676827582/jobs/6217967590 The authentication ones aren't related but the rest look like they are introduced by this PR. Please run the -api specs locally with your manageiq changes applied and the core repo linked via |
d192782
to
b5b83f4
Compare
b5b83f4
to
e7ac87e
Compare
@miq-bot cross-repo-tests ManageIQ/manageiq#22274 |
@galoiring Only members of the ManageIQ organization may use this command. |
@miq-bot cross-repo-tests ManageIQ/manageiq#22274 |
From Pull Request: ManageIQ/manageiq-api#1190
Core PR with product features has been merged |
@galoiring the spec failure looks legit please address |
e7ac87e
to
6b91918
Compare
…ies, storage resources and storage services
6b91918
to
fb9b172
Compare
Checked commit Autosde@fb9b172 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
@agrare fixed. |
We added the relevant endpoints and controllers.
They will be needed to access capability values fields added in:
ManageIQ/manageiq-schema#676
W/ @OrGur1987