New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable connection reuse for WebSocket connections in Apache #126
Conversation
BalancerMember ws://0.0.0.0:5007 | ||
BalancerMember ws://0.0.0.0:5008 | ||
BalancerMember ws://0.0.0.0:5009 | ||
BalancerMember ws://0.0.0.0:5000 disablereuse=On |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skateman This is nitpicky but it looks like you can use on
(lowercase) so it's consistent throughout this
file: http://blog.moserit.com/tuning-apaches-mod_proxy-and-tomcat-servers
Sorry. 🏃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jrafanie fixed
This is a temporary workaround for the issue described here: https://bugzilla.redhat.com/show_bug.cgi?id=1404354 This can be reverted after httpd is updated to 2.4.25 or newer
4e1e67f
to
242ee1e
Compare
Checked commit skateman@242ee1e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
... disablereuse=on
¯\_(ツ)_/¯ naming is hard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍
Note, this will need @carbonin @bdunne help to backport since @skateman's first PR is probably what we'd need to backport. ManageIQ/manageiq-gems-pending#217 |
@skateman As per the comment above, please create a separate PR for Fine. |
Since |
@simaishi here you go: ManageIQ/manageiq-gems-pending#219 |
Can I just backport ManageIQ/manageiq-gems-pending#219 to Euwe? |
Backported to Fine via ManageIQ/manageiq-gems-pending#219 |
Backported ManageIQ/manageiq-gems-pending#219 to Euwe. |
This is a temporary workaround for the issue described here:
https://bugzilla.redhat.com/show_bug.cgi?id=1404354
This can be reverted after httpd is updated to 2.4.25 or newer
@miq-bot add_label bug, fine/yes, euwe/yes
Replacement of: ManageIQ/manageiq-gems-pending#217
cc @psav, @gtanzillo, @jrafanie, @carbonin