Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable connection reuse for WebSocket connections in Apache #126

Merged
merged 1 commit into from Jun 28, 2017

Conversation

skateman
Copy link
Member

This is a temporary workaround for the issue described here:
https://bugzilla.redhat.com/show_bug.cgi?id=1404354

This can be reverted after httpd is updated to 2.4.25 or newer
@miq-bot add_label bug, fine/yes, euwe/yes

Replacement of: ManageIQ/manageiq-gems-pending#217

cc @psav, @gtanzillo, @jrafanie, @carbonin

@carbonin
Copy link
Member

@bdunne We will also need to add this for containers here

BalancerMember ws://0.0.0.0:5007
BalancerMember ws://0.0.0.0:5008
BalancerMember ws://0.0.0.0:5009
BalancerMember ws://0.0.0.0:5000 disablereuse=On
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skateman This is nitpicky but it looks like you can use on (lowercase) so it's consistent throughout this
file: http://blog.moserit.com/tuning-apaches-mod_proxy-and-tomcat-servers

Sorry. 🏃

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrafanie fixed

This is a temporary workaround for the issue described here:
https://bugzilla.redhat.com/show_bug.cgi?id=1404354

This can be reverted after httpd is updated to 2.4.25 or newer
@miq-bot
Copy link
Member

miq-bot commented Jun 28, 2017

Checked commit skateman@242ee1e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

... disablereuse=on ¯\_(ツ)_/¯ naming is hard

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@jrafanie jrafanie merged commit c954a4d into ManageIQ:master Jun 28, 2017
@jrafanie jrafanie added this to the Sprint 64 Ending Jul 3, 2017 milestone Jun 28, 2017
@jrafanie
Copy link
Member

Note, this will need @carbonin @bdunne help to backport since @skateman's first PR is probably what we'd need to backport. ManageIQ/manageiq-gems-pending#217

@skateman skateman deleted the disablereuse-websocket branch June 28, 2017 16:56
@simaishi
Copy link
Contributor

@skateman As per the comment above, please create a separate PR for Fine.

@skateman
Copy link
Member Author

@simaishi are you sure about the separate PR for fine? As far as I remember the add_ports has been dropped earlier and we need my old gems-pending solution for euwe only. cc @jrafanie

@simaishi
Copy link
Contributor

Since manageiq-balancer-websocket.conf doesn't exist in Fine branch, I'd assume we need the gems-pending PR for Fine/Euwe.

@skateman
Copy link
Member Author

@simaishi here you go: ManageIQ/manageiq-gems-pending#219
And what about euwe?

@simaishi
Copy link
Contributor

Can I just backport ManageIQ/manageiq-gems-pending#219 to Euwe?

@simaishi
Copy link
Contributor

simaishi commented Jul 6, 2017

Backported to Fine via ManageIQ/manageiq-gems-pending#219

@simaishi
Copy link
Contributor

simaishi commented Jul 7, 2017

Backported ManageIQ/manageiq-gems-pending#219 to Euwe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants